Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align core changes #228

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Align core changes #228

merged 3 commits into from
Nov 7, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Nov 7, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

@sverdlov93 sverdlov93 added the ignore for release Automatically generated release notes label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

github-actions bot commented Nov 7, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/go 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit/sca/python 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/go/golang.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/sca/python/python.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@attiasas attiasas merged commit 42cf964 into jfrog:dev Nov 7, 2024
59 checks passed
barv-jfrog pushed a commit to barv-jfrog/jfrog-cli-security that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants