Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect project env var on build discard and promote #2076

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Respect project env var on build discard and promote #2076

merged 1 commit into from
Jul 13, 2023

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Following #2038
Respect the JFROG_CLI_BUILD_PROJECT environment variable if the --project option is not provided in the jf rt build-discard and jf rt build-promote commands.

@RobiNino RobiNino added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jul 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 13, 2023
@RobiNino RobiNino changed the base branch from v2 to dev July 13, 2023 13:34
@RobiNino RobiNino merged commit ef7f99c into jfrog:dev Jul 13, 2023
1 check failed
@chenrui333 chenrui333 mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @sverdlov93