Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --tar flag to support docker scan of .tar files without docker engine installed #2451

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add --tar flag to support docker scan of .tar files without docker engine installed #2451

wants to merge 2 commits into from

Conversation

guyshe-jfrog
Copy link

@guyshe-jfrog guyshe-jfrog commented Feb 25, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Part of jfrog/jfrog-cli-security#30

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@guyshe-jfrog guyshe-jfrog mentioned this pull request Feb 25, 2024
Closed
6 tasks
attiasas
attiasas requested changes Feb 26, 2024
View reviewed changes
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@attiasas attiasas added the improvement Automatically generated release notes label Feb 26, 2024
attiasas
attiasas reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the PR name to fit the changes

@guyshe-jfrog @attiasas
Fix phrasing of docs
9df1525 
Co-authored-by: Assaf Attias <[email protected]>
@guyshe-jfrog guyshe-jfrog changed the title Feature/docker scan tar dev Add --tar flag to support docker scan of .tar files without docker engine installed May 2, 2024
@yahavi yahavi changed the base branch from v2 to dev August 16, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyshe-jfrog @attiasas