Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go mod tidy #2529

Closed
wants to merge 1 commit into from
Closed

Run go mod tidy #2529

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link

Otherwise certain go commands complain that the go mod is wrong and needs fixing.

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Copy link
Contributor

github-actions bot commented Apr 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SuperSandro2000
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Apr 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 21, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea
Copy link
Contributor

Hey @SuperSandro2000,

Thanks for submitting the PR.

We've recently updated the CLI to Go 1.22.3, which should resolve the issue you encountered. We didn't merge your PR since updating the Go version affects some of our internal release tools.

I'm closing this pull request, but feel free to reach out if you have any questions.

@SuperSandro2000
Copy link
Author

We didn't merge your PR since updating the Go version affects some of our internal release tools.

Newer go versions are a lot more strict about using older or newer versions for no good reason sadly...

Now I am encountering the following but I can work around that

 ▶ go mod tidy
go: go.mod requires go >= 1.22.3 (running go 1.22.2; GOTOOLCHAIN=local)

The new go toolchain changes are annoying....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants