Fail 'jf docker scan/push/pull' when a wrong flag is provided to the command #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
requested a deployment
to
frogbot
GitHub Actions
Waiting
eranturgeman
requested a deployment
to
frogbot
GitHub Actions
Waiting
eranturgeman
added
safe to test
github-actions
bot
removed
the
safe to test
Open
6 tasks
eyalbe4
added
bug
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Sep 5, 2024
There was a problem hiding this comment.
@eranturgeman,
Will you be able fix the jfrog-cli-security version in the go.mod, to allow the tests to pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....When a wrong flag is provided to the command it is captured as an argument and therefore is not going through flags validations. This causes the flag to be ignored and without indications on anything wrong.
Since 'jf docker scan/push/pull' expects 2 arguments only: 'docker' + one of the commands, and extra argument indicates wrong usage.
I added a validation on the arguments number to capture this issue