Adding .NET examples and deleting old NuGet examples #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranturgeman
requested review from
sverdlov93 and
yahavi
and removed request for
sverdlov93
yahavi
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Please consider the following changes:
- Let's add a README explaining with a few words about the examples and how to use the JFrog CLI for NuGet. See https://github.com/jfrog/project-examples/tree/master/gradle-examples for reference.
- Rename the directory "nuget-example" -> "nuget-examples"
|
@yahavi Do you think we can also remove |
|
Yes @sverdlov93.
|
…to add-nuget-example
eranturgeman
changed the title
eranturgeman
changed the title
eranturgeman
changed the title
yahavi
requested changes
Oct 1, 2023
yahavi
reviewed
Oct 1, 2023
Co-authored-by: Yahav Itzhak <[email protected]>
…examples into add-nuget-example
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
yahavi
reviewed
Oct 2, 2023
Co-authored-by: Yahav Itzhak <[email protected]>
…examples into add-nuget-example
yahavi
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted old nuget-examples directory
Added new dotnet-examples directory with 2 examples:
single-example
multi-example