Unify/remove media position reset on Play #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bijington
approved these changes
Nov 21, 2022
jfversluis
added a commit
that referenced
this pull request
Sep 4, 2023
* Fix (#37) * Add Speed property (#26) * Add Speed property to AudioPlayer * Add Speed property to sample app and handle speed limitations on different Android devices * Add handling for exceptions, speed out of range and Android API level < 23 * Add SpeedOutOfRangeException handling in sample application * Add Speed property to NET6_0 definition * Add CanSetSpeed handing in Sample App * Fix bad merge whoops * Fix speed clamping on iOS and Android * Fix Windows Speed * PR Feedback * Update Sample * Update AudioPlayer.net.cs * Update MusicPlayerPageViewModel.cs * Update src/Plugin.Maui.Audio/AudioPlayer.android.cs * Update src/Plugin.Maui.Audio/AudioPlayer.net.cs Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Update README with Speed related properties (#38) * Update README.md * Update README.md * Windows and Android recording tested. iOS not yet tested. * Add NSMicrophoneUsageDescription to Info.plist * loosen permission on mic for MacCatalyst * implemented LastDuration for recorder * try to get player to play again but CollectionView will not take 2nd click * duration working for both recorder and player * <ProvisioningType>automatic</ProvisioningType> * removed all warnings by dealing with nullability * build nuget package * Fix funky formatting and remove unnecessary audio player bits * Removed unnecessary recording bits * A bit more tidy up * Recorder page shows the time recording * Smoother audio recording experience on macOS * Recommended way to check for permissions * Make Android non blocking on StartAsync * XML comments and further tidy up * Fix windows compilation errors * Revert "Merge branch 'main' into pr/39" This reverts commit 415a6bd, reversing changes made to 2d00bbc. * Remove auto added bits * Apply suggestions from code review Co-authored-by: Gerald Versluis <[email protected]> * Some docs --------- Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Gerald Versluis <[email protected]>
jfversluis
added a commit
that referenced
this pull request
Sep 4, 2023
* Initial dump of things * Musings on how the recording could look * Hacked together sample to try and prove it works * Feature/add audio recording - tested on Windows, Mac, Android (#39) * Fix (#37) * Add Speed property (#26) * Add Speed property to AudioPlayer * Add Speed property to sample app and handle speed limitations on different Android devices * Add handling for exceptions, speed out of range and Android API level < 23 * Add SpeedOutOfRangeException handling in sample application * Add Speed property to NET6_0 definition * Add CanSetSpeed handing in Sample App * Fix bad merge whoops * Fix speed clamping on iOS and Android * Fix Windows Speed * PR Feedback * Update Sample * Update AudioPlayer.net.cs * Update MusicPlayerPageViewModel.cs * Update src/Plugin.Maui.Audio/AudioPlayer.android.cs * Update src/Plugin.Maui.Audio/AudioPlayer.net.cs Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Update README with Speed related properties (#38) * Update README.md * Update README.md * Windows and Android recording tested. iOS not yet tested. * Add NSMicrophoneUsageDescription to Info.plist * loosen permission on mic for MacCatalyst * implemented LastDuration for recorder * try to get player to play again but CollectionView will not take 2nd click * duration working for both recorder and player * <ProvisioningType>automatic</ProvisioningType> * removed all warnings by dealing with nullability * build nuget package * Fix funky formatting and remove unnecessary audio player bits * Removed unnecessary recording bits * A bit more tidy up * Recorder page shows the time recording * Smoother audio recording experience on macOS * Recommended way to check for permissions * Make Android non blocking on StartAsync * XML comments and further tidy up * Fix windows compilation errors * Revert "Merge branch 'main' into pr/39" This reverts commit 415a6bd, reversing changes made to 2d00bbc. * Remove auto added bits * Apply suggestions from code review Co-authored-by: Gerald Versluis <[email protected]> * Some docs --------- Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Merge Speed functionality * Update CI * Revert "Update CI" This reverts commit de9e99a. * Update CI * Update AudioPlayer.android.cs * Apply suggestions from code review --------- Co-authored-by: charles david young <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Johan Svensson <[email protected]> Co-authored-by: Gerald Versluis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when you call Play, the position would be reset.
In my mind, resetting the position is something that belongs to the Stop. When I pause I want to be able to press play again to resume playing. Only when I press stop I expect playback to be reset whenever I start again.
Additionally, I think for iOS there was inconsistent behavior when Play was called it didn't pause the playback as it does on other platforms.