feat: Recurse into target paths if -r is given #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding -r lets the user specify a top level folder which we then descend into recursively. Adding a large folder structure would have made the program grind to a halt before showing the rendered GUI. To avoid this, a safety limit of 500 total files is introduced (for both recursive and non-recursive finding of images). Users will probably not notice this, since handling that many files manually would be a tedious task. By ignoring errors, we won't descend into those directories, but we will descend into everything else. This let's us cast a wide net with the input directories, and handle it optimistically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding -r lets the user specify a top level folder which we then descend into recursively.
Adding a large folder structure would have made the program grind to a halt before showing the rendered GUI. To avoid this, a safety limit of 500 total files is introduced (for both recursive and non-recursive finding of images). Users will probably not notice this, since handling that many files manually would be a tedious task.
By ignoring errors, we won't descend into those directories, but we will descend into everything else. This let's us cast a wide net with the input directories, and handle it optimistically.