Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with citations in footnotes #6813

Closed
denismaier opened this issue Nov 5, 2020 · 12 comments
Closed

Some issues with citations in footnotes #6813

denismaier opened this issue Nov 5, 2020 · 12 comments

Comments

@denismaier
Copy link
Contributor

This here gives me wrong results with the latest pandoc version:

---
references:
- type: book
  id: doeA
  author:
  - family: Doe
    given: John
  title: 'Title A'
- type: book
  id: doeB
  author:
  - family: Doe
    given: John
  title: 'Title B'
---

[^1] [^2] [^3] [^4]


[^1]: @doeA Some text in between. Also @doeB.

[^2]: @doeB

[^3]: @doeB

[^4]: @doeA.

This gives me these footnotes:

[^1]: 1 Some text in between. Also Doe, *Title B*, n.d.

[^2]: Doe,

[^3]: Doe,

[^4]: 1.  

Couple of issues:

  1. There's a incorrect ibid in the second footnote. I think here we would want the short form.
  2. The ibid in footnote 3 is correct, but note the comma.
  3. The period in footnote 4 seems to start an enumeration.
  4. Footnote 1 shows that the enumeration is actually started even without a period. (Is the @ starting a list here?)
@jgm
Copy link
Owner

jgm commented Nov 5, 2020

What style are you using?
With current master, I get this (with pandoc --citeproc -t plain --csl chicago-fullnote-bibliography.csl):

[1] 1 Some text in between. Also John Doe, Title B, n.d.

[2] Doe, ibid

[3] Doe, ibid

[4] 1.  

@jgm
Copy link
Owner

jgm commented Nov 5, 2020

Yes, @doeA. does conform to the spec for an example list item.
I guess you'd need to write @doeA\. to avoid this.

@jgm
Copy link
Owner

jgm commented Nov 5, 2020

And the @doeA in your first note is turning into 1 because it's being treated as a reference to the example list item below...

@jgm
Copy link
Owner

jgm commented Nov 5, 2020

With the backslash, I get:

[1] John Doe, Title A, n.d Some text in between. Also John Doe, Title B,
n.d.

[2] Doe, ibid

[3] Doe, ibid

[4] Doe, Title A, n.d.

which looks right except for the missing periods after "ibid". That does seem to be a bug, but in pandoc, not the citeproc library.

@jgm jgm transferred this issue from jgm/citeproc Nov 5, 2020
@jgm
Copy link
Owner

jgm commented Nov 5, 2020

Oh, and yes, I see the point about the ibid in n. 2.
I guess that is a citeproc library issue.

@denismaier
Copy link
Contributor Author

denismaier commented Nov 5, 2020

What style are you using?

Chicago-note-bibliography.csl
Sorry, forgot to include that info

jgm added a commit that referenced this issue Nov 5, 2020
Previously in-text note citations inside a footnote
would sometimes have the final period stripped, even
if it was needed (e.g. on the end of 'ibid').

See #6813.
@jgm
Copy link
Owner

jgm commented Nov 5, 2020

OK, with the latest change I'm getting:

[1] Doe, Title A. Some text in between. Also Doe, Title B.

[2] Doe, ibid.

[3] Doe, ibid.

[4] Doe, Title A.

Everything okay now I think, except the ibid in n. 2.

@jgm
Copy link
Owner

jgm commented Nov 5, 2020

Actually I think this is also a pandoc issue. We need to recognize when these citations occur inside a note and set citationNoteNum accordingly. Sorry, we are doing that correctly.

@jgm
Copy link
Owner

jgm commented Nov 5, 2020

Actually I think we conform to the CSL spec: "the current cite is the first cite in the citation, and the previous citation consists of a single cite referencing the same item."

Note that you have two citations in the first note. So the "previous citation" is to @doeB.

I know, it's a bit unexpected, because if you'd done a regular note citation
[@doeA; @doeB] then this whole thing wolud be considered one citation and the ibid would not be triggered.

But this is all a result of in-text citations not being really integrated into the spec.

@jgm jgm closed this as completed Nov 5, 2020
@denismaier
Copy link
Contributor Author

Ok. Looks like we need to amend the spec here. The ibid in note 2 is not wanted. I think citeproc-js suppresses that already. See citation-style-language/documentation#121

@jgm jgm reopened this Nov 6, 2020
@jgm
Copy link
Owner

jgm commented Nov 6, 2020

I think I can get that behavior by modifying citeproc.

jgm added a commit to jgm/citeproc that referenced this issue Nov 6, 2020
In calculating whether an item is alone in its citation,
we need to take into account citationNoteNumber, since
two citations may occur in the same note and they should
not be ranked "alone."

See jgm/pandoc#6813, citation-style-language/documentation#121
@jgm
Copy link
Owner

jgm commented Nov 6, 2020

OK, I've fixed it in citeproc.

@jgm jgm closed this as completed Nov 6, 2020
jgm added a commit that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants