Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve center environment #6852

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

ip1981
Copy link
Contributor

@ip1981 ip1981 commented Nov 17, 2020

No description provided.

@ip1981 ip1981 force-pushed the ip1981/reader/latex/center branch 2 times, most recently from 6b52e7f to e96042a Compare November 22, 2020 16:40
Copy link
Collaborator

@tarleb tarleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to run the test suite with --accept, e.g. via

make test TESTARGS=--accept

I don't have a fully formed opinion on whether this is an desirable change or not. Conversions will be always lossy, and centering is a presentational detail that's not the focus. OTOH, this would certainly be helpful when converting to HTML.

src/Text/Pandoc/Readers/LaTeX.hs Outdated Show resolved Hide resolved
@ip1981 ip1981 marked this pull request as draft November 25, 2020 11:54
@ip1981 ip1981 marked this pull request as ready for review November 26, 2020 17:37
@jgm jgm merged commit 630b1bf into jgm:master Nov 26, 2020
@jgm
Copy link
Owner

jgm commented Nov 26, 2020

Great, thanks!

@ip1981 ip1981 deleted the ip1981/reader/latex/center branch November 27, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants