Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe height auto makes embedded Youtube videos smaller in height and there is no workaround #2622

Closed
FabianRohr opened this issue Sep 9, 2019 · 4 comments

Comments

@FabianRohr
Copy link

I don't know what's the idea behind

img, embed, iframe, object, video { height: auto; max-width: 100%; }

but it´s not working for me. And I can't even overwrite it, there is no option for "height" that can undo this. So I can not use Bulma at the moment whatsoever.

@ven0ms99
Copy link

ven0ms99 commented Sep 13, 2019

@jonas-scytech
Copy link

This is fixed on master and its already on the changelog (#2060 412bef4) but not released yet.

For now I think the best workaround is to replace @import "node_modules/bulma/sass/base/minireset"; with a direct import of minireset.css

@iainhallam
Copy link

Still being affected by this, so I've removed the same lines as 412bef4 in my copy.

@bpugh
Copy link

bpugh commented Oct 25, 2019

Looks like the fix for this is now included in the 0.8.0 release 🎉
so this issue can probably be closed now.

@jgthms jgthms closed this as completed Oct 25, 2019
earthboundkid added a commit to spotlightpa/poor-richard that referenced this issue Jan 22, 2020
Somehow, we became affected by jgthms/bulma#2622 even though I didn't change versions of Bulma. Working around it by upgrading to Bulma 8.0. This has the downside of making buttons slightly larger and tweaking some colors, but it's not very noticeable in my browsing.
earthboundkid added a commit to spotlightpa/poor-richard that referenced this issue Jan 22, 2020
Somehow, we became affected by jgthms/bulma#2622 even though I didn't change versions of Bulma. Working around it by upgrading to Bulma 8.0. This has the downside of making buttons slightly larger and tweaking some things, but it can be mostly undone with more SCSS rules.
earthboundkid added a commit to spotlightpa/poor-richard that referenced this issue Jan 22, 2020
Somehow, we became affected by jgthms/bulma#2622 even though I didn't change versions of Bulma. Working around it by upgrading to Bulma 8.0. This has the downside of making buttons slightly larger and tweaking some things, but it can be mostly undone with more SCSS rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants