Mixins.scss uses un-imported variables.

[Didel]

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version 0.8.0
This is a Sass issue.
I am almost sure this issue is not a duplicate.

Description

Utilities/mixins.scss includes@import "initial-variables" in order to resolve the variables used in the various defined mixins. However, version 0.8.0 includes a mixin (=delete) that makes use of the $scheme-invert variable, while it is not specified in the included initial-variables.scss .

This will cause a problem if you only import the mixins, because the $scheme-invert variable will be undefined.

Steps to Reproduce

• Create a new .scss file
• Import the mixins.scss from Bulma (e.g. @import "./node_modules/bulma/sass/utilities/mixins";)
• compile the .scss file you created above.

Expected behavior

No compilation errors.

Actual behavior

I got a compiler error:

{
  "status": 1,
  "file": "../node_modules/bulma/sass/utilities/mixins.sass",
  "line": 173,
  "column": 26,
  "message": "Undefined variable: \"$scheme-invert\".",
  "formatted": "Error: Undefined variable: \"$scheme-invert\".\n        on line 173 of node_modules/bulma/sass/utilities/mixins.sass, in mixin `delete`\n        from line 236 of node_modules/bulma/sass/utilities/mixins.sass\n        from line 1 of src/base/mixins.scss\n        from line 4 of src/base/all.scss\n>>   background-color: rgba($scheme-invert, 0.2);\n\n   -------------------------^\n"
}

[Didel]

I have created Pull-Request #2774 that will fix this issue.

[crabnky]

Have the same - when can I expect fix to be released?

[dicren]

Meanwhile I fix it importing all the files that are necessary

@import "~bulma/sass/utilities/functions";
@import "~bulma/sass/utilities/initial-variables";
@import "~bulma/sass/utilities/derived-variables";
@import "~bulma/sass/utilities/mixins";

[gonzofish]

@dicren I believe initial-variables is already imported into mixins

[CallumWatkins]

@dicren I believe initial-variables is already imported into mixins

derived-variables also requires initial-variables to be imported first, regardless of mixins.

[gonzofish]

Ah, right, @CallumWatkins, good point!

[Didel]

@dicren I believe initial-variables is already imported into mixins

derived-variables also requires initial-variables to be imported first, regardless of mixins.

@gonzofish Exactly, that is why in #2774 I've also added the derived-variables import to mixins.sass. This way, you can choose to only import mixins.sass without having to worry about importing other dependencies.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Didel]

I don’t agree with the Stale bot. As the PR hasn’t been merged yet, it should not be closed.

[Artem-Schander]

It takes almost four years to fix this issue?

[Didel]

It takes almost four years to fix this issue?

@Artem-Schander I don’t know what you mean, this ticket was created in January of this year.

@jgthms what a great way to show how thankful you are to people who contribute. After 10 months of (seeming) inactivity, you close the issue by ignoring the created PR, and instead create a commit of your own without any credit to someone who has supplied (part of) the solution. Then you continue to close this ticket without any message, at least a simple ‘thank you for your contribution’ would have been nice.

If it takes 10 months to look into a change of 1 line of scss, together with what I said in the lines above, that does raise serious questions about the state of the project and its maintainers. The open source community is a wonderful community, but if you treat them like this, don’t expect people to actively contribute in the future any more.

[Artem-Schander]

@Didel You‘re right. My bad. I‘ve seen the 17 and thought, what a long time.
However, 10 months is a long time for this kind of issue as well.
I subscribed to this issue a long time ago and would like to see the PR merged or the issue resolved. It sucks that i can not use the scss for the newer stuff.

[dbryar]

Latest NPM package (0.9.1) still does not have this issue fixed so the build fails in a TypeScript VueJS app without the PR included.

[alexd73]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/bulma/sass/utilities/mixins.sass b/node_modules/bulma/sass/utilities/mixins.sass
index 0ed78c1..7c5ee20 100644
--- a/node_modules/bulma/sass/utilities/mixins.sass
+++ b/node_modules/bulma/sass/utilities/mixins.sass
@@ -1,4 +1,5 @@
 @import "initial-variables"
+@import "derived-variables"
 
 =clearfix
   &::after

This issue body was partially generated by patch-package.