Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sup and sub to titles and subtitles #1343

Merged
merged 3 commits into from
Nov 7, 2017
Merged

Adds sup and sub to titles and subtitles #1343

merged 3 commits into from
Nov 7, 2017

Conversation

SimplyThomas
Copy link

This is a new improvement.

Proposed solution

This PR fixes sizing when using either <sub> and <sup> elements inside a .title element.

Testing Done

Compiled with yarn and tested across all of the various sizes and configurations.

Before:
screen shot 2017-10-19 at 11 31 59 pm

After:
screen shot 2017-10-19 at 11 32 15 pm
screen shot 2017-10-19 at 11 32 32 pm

@jgthms
Copy link
Owner

jgthms commented Oct 19, 2017

I’d rather keep it consistent with the .content sup and sub who have a font size of 75%.

@SimplyThomas
Copy link
Author

@jgthms this is also a better implementation. Tested in the same way as before, cycling through the various sizes. Also verified that the variables work as intended.

@jgthms
Copy link
Owner

jgthms commented Oct 20, 2017

Why does it appear twice? Just add it to the first rule set.

@SimplyThomas
Copy link
Author

@jgthms One's for .title, the other is for .subtitle

@jgthms
Copy link
Owner

jgthms commented Oct 20, 2017

I’m not sure we would want a different size for both title and subtitle since they can both be all sizes from 1 to 7 anyway.

Merged the .title and .subtitle sub and sup variables into just one $title-sub-size and $title-sup-size
@SimplyThomas
Copy link
Author

@jgthms I have updated it to reflect just one size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants