Makes adding colors easier #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just map your colors, the bulma way ($name: ($color[,$invert]) into $custom-colors, and import bulma. Note that, you can provide only the color as the inverted would be computed from it.
|
Nice! I'll have a look. |
|
Great stuff! I'm gonna add some documentation, and also add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a improvement.
As bulma colors are kind hard-coded into a map, which wrap colors and functions (findColorInvert), to extend them you have to import variables and functions then customize your style, then import derived variables and reassing colors to a merged map. Damn this is heavy. I've come to solution where you set you customizations to $custom-colors variable, the way bulma does, and then you import bulma, done.
Proposed solution
Add a function in
utilities/functions.sassthat handle$custom-colorsto merge it with bulma's$colorsdroping malformated elements. Assing it to$colorsinutilities/derived-variables.sassso it can be overriden and is backward compatible with 'old' integrations.Tradeoffs
Can't see anyone... 1 call over whole project, with relatively small maps
Testing Done
Customized through
$custom-colorswith malformated elements, then compiled and used in html page. All custom (proper) and base colors where accessible with.is-#{name}classes dependent of colors.