Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded footer padding with new footer-padding variable (Fixes #1878) #2167

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

trentpeterson
Copy link
Contributor

This change addresses the problem of having hard-coded padding in the footer. It is an improvement to make the footer more flexible.

Proposed solution

This small change adds a new $footer-padding variable. If the variable is not overridden the previously hard-coded default value is used.

Fixes #1878.

Tradeoffs

None - works the same as it did previously if the variable isn't overridden.

Testing Done

I tested with the variable enabled and disabled and it works as expected in my local project that utilizes node-sass for compilation. I also searched for any collisions with an existing $footer-padding variable and did not find any.

This is a tiny change. My only question would be about the consistency of padding customization. Some items have individual variables for vertical and horizontal padding, while others (like this one) have a single padding variable. I don't see an advantage of one over the other besides consistency, but maybe someone else does. An easy change regardless.

Thank you!

@jgthms jgthms merged commit a9b5d28 into jgthms:master Oct 28, 2018
@jgthms
Copy link
Owner

jgthms commented Oct 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants