Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper aligning for tabs #2175

Merged
merged 7 commits into from
May 18, 2019
Merged

proper aligning for tabs #2175

merged 7 commits into from
May 18, 2019

Conversation

diomed
Copy link
Contributor

@diomed diomed commented Oct 23, 2018

This is a bugfix.

Proposed solution

[x] fix for #2172

replaces center with baseline, so all tabs are properly aligned.

@jgthms
Copy link
Owner

jgthms commented Oct 23, 2018

Do you have an example where this is an issue?

@diomed
Copy link
Contributor Author

diomed commented Oct 23, 2018

example is shown in issue which I'm closing.
problem is explained here

@jgthms jgthms self-assigned this Oct 23, 2018
@jgthms
Copy link
Owner

jgthms commented Oct 28, 2018

The solution for that particular problem is to change the following rule in content.sass:

li + li
  margin-top: 0.25em

And make sure it's not applied for tabs.

@diomed
Copy link
Contributor Author

diomed commented Oct 28, 2018

so do I change to 0 and modify PR?
is this it?

@jgthms
Copy link
Owner

jgthms commented Oct 28, 2018

Yeah change this PR so this selector li + li doesn't target li that are within a .tabs.

@diomed diomed changed the title adds baseline to tabs ul proper aligning for tabs Oct 29, 2018
@diomed
Copy link
Contributor Author

diomed commented Nov 2, 2018

didn't I get it?
is this good in the end or not?
I'm unsure why it's not merged

@jgthms
Copy link
Owner

jgthms commented Nov 2, 2018

No that’s the wrong output. The “not tabs” part should be for the ul, not the li.

@diomed
Copy link
Contributor Author

diomed commented Dec 5, 2018

@jgthms so - like this then?

if not the case, can you please update it properly so this one could be fixed already.

@jgthms
Copy link
Owner

jgthms commented May 17, 2019

Just add before // Sizes:

.tabs
  li + li
    margin-top: 0

@jgthms
Copy link
Owner

jgthms commented May 17, 2019

You've indented that one level too far. And you can remove the rest.

@diomed
Copy link
Contributor Author

diomed commented May 17, 2019

like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants