-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proper aligning for tabs #2175
proper aligning for tabs #2175
Conversation
[x] fix for jgthms#2172
Do you have an example where this is an issue? |
example is shown in issue which I'm closing. |
The solution for that particular problem is to change the following rule in li + li
margin-top: 0.25em And make sure it's not applied for tabs. |
so do I change to 0 and modify PR? |
Yeah change this PR so this selector |
didn't I get it? |
No that’s the wrong output. The “not tabs” part should be for the ul, not the li. |
@jgthms so - like this then? if not the case, can you please update it properly so this one could be fixed already. |
Just add before .tabs
li + li
margin-top: 0 |
You've indented that one level too far. And you can remove the rest. |
like this? |
This is a bugfix.
Proposed solution
[x] fix for #2172
replaces center with baseline, so all tabs are properly aligned.