make the default text color of code listings more accessible #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix supporting #53.
Proposed solution
The original red code text on grey background doesn't pass the https://webaim.org/resources/contrastchecker/ on background #F5F5F5
This change fixes this by changing text color #f14668 to #da1039
Tradeoffs
None
Testing Done
NPM Build. Screenshot constract checker below:
Before: https://webaim.org/resources/contrastchecker/?fcolor=F14668&bcolor=F5F5F5
After: https://webaim.org/resources/contrastchecker/?fcolor=DA1039&bcolor=F5F5F5
Changelog updated?
No.
Suggested text: "Darken text color of code element to pass AA accessibility"