Give arbitrary elements access to the image/ratio classes #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
I often want to make other elements besides images sized to a particular ratio. With this solution, rather than the ratio classes only responding to
.image > img
, I propose adding a.image > .has-ratio
class which can be applied to any element (e.g.<iframe>
,<video>
, etc).A practical example would be the following:
Tradeoffs
.image
class, which could be misleading depending on what the child element is.video
,iframe
) rather than adding another class, but that would limit its utility and increase the CSS size much more.Testing Done
I implemented the example described in the proposal to verify it effects all elements with the
.has-ratio
class the same way it effectsimg
.