Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to instance #78

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add description to instance #78

merged 1 commit into from
Dec 21, 2023

Conversation

6543
Copy link
Contributor

@6543 6543 commented Dec 6, 2023

move wily used nodeDescription into the normal spec.
this also should contain more instance configured specific information.

@6543
Copy link
Contributor Author

6543 commented Dec 6, 2023

about limit length

the-federation.info database has this:

select node.domain,LENGTH(d::text) as l from (select node_id,data->'metadata'->'nodeDescription'::text as d from node_info where data->'metadata'->'nodeDescription' IS NOT NULL) JOIN node on node.id=node_id order by l desc limit 30;
           domain           |  l   
----------------------------+------
 el-spot.xyz                | 2443
 banana.dog                 | 2069
 peertube.uno               | 1722
 hereisliberty.com          | 1040
 twely.etn.icu              | 1035
 lessthanthree.cc           | 1020
 novoa.nagoya               | 1020
 misskey.takehi.to          | 1017
 sloth.run                  | 1013
 tube3.apolut.net           | 1003
 soratomo.info              |  980
 ein.shg-blog.de            |  976
 madost.one                 |  972
 misskey.kindworld.one      |  964
 matrix.rocks               |  964
 k.lapy.link                |  949
 gp.lapy.link               |  949
 nekomiya.net               |  947
 mewblog.thepolarbear.co.uk |  946
 genau.qwertqwefsday.eu     |  942
 firefish.crazy-to-bike.de  |  939
 lovers.alice.rest          |  936
 animalesenfu.ga            |  865
 misskey.dev                |  862
 beta.kokonect.link         |  844
 live.people-world-life.de  |  827
 sns.marosuke2600.work      |  824
 sudo.mkdir.uk              |  820
 social.bloodshed.party     |  814
 netzkae.se                 |  795

schemas/2.2/schema.json Outdated Show resolved Hide resolved
schemas/2.2/schema.json Outdated Show resolved Hide resolved
schemas/2.2/schema.json Outdated Show resolved Hide resolved
schemas/2.2/schema.json Outdated Show resolved Hide resolved
@6543 6543 changed the title Blocked: Add description to instance Add description to instance Dec 10, 2023
@6543 6543 marked this pull request as ready for review December 10, 2023 21:26
schemas/2.2/schema.json Outdated Show resolved Hide resolved
@6543 6543 requested a review from jhass December 13, 2023 08:37
@6543 6543 force-pushed the v2.2/nodeDescription branch 2 times, most recently from 07aa87c to ae1a6b5 Compare December 17, 2023 15:48
this should describe the instance and might also be markdown formated

Co-authored-by: Jonne Haß <[email protected]>
@6543
Copy link
Contributor Author

6543 commented Dec 17, 2023

@jhass okay, let's not make the optional format suggestion a blocker for this. I'll open a new pull request to keep track of this and discuss it once this got merged.

@jhass jhass merged commit ac23558 into jhass:main Dec 21, 2023
1 check passed
@jhass
Copy link
Owner

jhass commented Dec 21, 2023

Thank you, I didn't mean to block this, I was just busy elsewhere for the past couple days 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants