-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to instance #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about limit lengththe-federation.info database has this: select node.domain,LENGTH(d::text) as l from (select node_id,data->'metadata'->'nodeDescription'::text as d from node_info where data->'metadata'->'nodeDescription' IS NOT NULL) JOIN node on node.id=node_id order by l desc limit 30;
|
6543
commented
Dec 6, 2023
6543
commented
Dec 6, 2023
6543
force-pushed
the
v2.2/nodeDescription
branch
from
December 6, 2023 21:23
b22ae55
to
39a1b87
Compare
jhass
reviewed
Dec 10, 2023
6543
force-pushed
the
v2.2/nodeDescription
branch
from
December 10, 2023 21:24
482d245
to
706feb9
Compare
6543
commented
Dec 10, 2023
6543
force-pushed
the
v2.2/nodeDescription
branch
from
December 10, 2023 21:26
7beb1f4
to
9efd137
Compare
6543
changed the title
Blocked: Add description to instance
Add description to instance
Dec 10, 2023
6543
commented
Dec 10, 2023
6543
force-pushed
the
v2.2/nodeDescription
branch
2 times, most recently
from
December 17, 2023 15:48
07aa87c
to
ae1a6b5
Compare
this should describe the instance and might also be markdown formated Co-authored-by: Jonne Haß <[email protected]>
6543
force-pushed
the
v2.2/nodeDescription
branch
from
December 17, 2023 15:48
ae1a6b5
to
35ab94c
Compare
@jhass okay, let's not make the optional format suggestion a blocker for this. I'll open a new pull request to keep track of this and discuss it once this got merged. |
Thank you, I didn't mean to block this, I was just busy elsewhere for the past couple days 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move wily used
nodeDescription
into the normal spec.this also should contain more instance configured specific information.