Enable GC.auto_compact in test suite #101
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5b0579f fixes the crash, but now some tests are failing. I don't really have quite the full context here to know what else may be missing. |
joshuay03
force-pushed
the
main
branch
2 times, most recently
from
6f1d6a6
to
757871e
Compare
joshuay03
force-pushed
the
test-with-auto-compaction
branch
from
51ec473
to
162275e
Compare
joshuay03
force-pushed
the
test-with-auto-compaction
branch
from
162275e
to
a4babd8
Compare
|
Oh thank you so much (I'm really not familiar with C++). |
No worries, I’m still getting the hang of it too. It’d be preferable to have @jhawthorn’s sign-off on this. |
|
Thanks! I didn't know y'all were using retained profiling that's cool. Auto compaction seemed to reproduce this consistently but I added an explicit test using verify_compaction_references in 702b139 to be sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces: #100
cc @jhawthorn