Rename allocation_sample_rate to allocation_interval
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhawthorn Please let me know if you have any strong reservations about this. |
|
Thanks! I think this name is better but I want to keep the old kwarg working as a fallback option, otherwise it's too likely this silently fails for users. I don't think we need to document or deprecate it (yet?). |
jhawthorn
deleted the
rename-allocation-sample-rate-to-allocation-interval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Renames the CLI flag from
--allocation_sample_rateto--allocation-interval(hyphen for consistency with--start-paused, also pretty standard).Renames the option kwarg from
allocation_sample_ratetoallocation_interval. Also renamed vars to match.