Improve the project's setup #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 26, 2021 09:35
No need to set the global flag. Instead flag is set only for the target that are of our interest.
LCOV seems to be a better choice as now we get a nice html report. Note that target's name has been changed so that it describes better the target job instead of the tool that target is using, as tool might change in the future.
Comment describes now better what the target does, and uses build system independent command.
`include(CTest)` is a suggested way of enabling project's tests. Under the hood it will call `enable_testing()` but as well it will properly configure ctest.
Project shall be configured in a way that building and running tests can be skipped. From now on if `-DBUILD_TESTING=OFF` is set during the build file generation, target related to the tests won't be build.
`covr` target shall not build `test` target as otherwise the coverage won't be calculated if there are failing tests. Instead both target shall be build separately i.e.: ```bash cmake --build <build_dir> --target test cmake --build <build_dir> --target covr ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covrandtesttargetscovrtarget's comment--coveragecompiler flag on the target