Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign DeserializerAdapter trait to support deserializing using DeserializeSeed #313

Closed
wants to merge 22 commits into from
Closed

Redesign DeserializerAdapter trait to support deserializing using DeserializeSeed #313

wants to merge 22 commits into from

Commits on Dec 13, 2023

  1. Add DeserializeSeed support

    @phil-opp
    phil-opp committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e2fd400 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Add DefaultSeed trait to allow deserializing discovery messages again 

    Discovery messages don't implement the serde Deserialize traits because they need an additional encoding value for Deserialization. By using a custom DefaultSeed trait, we can at least work around this issue by providing a dummy implementation.
    @phil-opp
    phil-opp committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    e4a7ee4 View commit details
    Browse the repository at this point in the history

  2. Start replacing DeserializeSeed trait with custom `FromBytesWithEnc… 

    …oding` trait
    @phil-opp
    phil-opp committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b01ca98 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Implement FromBytesWithEncoding for Cdr deserializer

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    85d55a4 View commit details
    Browse the repository at this point in the history

  2. Implement FromBytesWithEncoding for PlCdr deserializer

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    70a9bf4 View commit details
    Browse the repository at this point in the history

  3. Remove unused imports

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4273dc5 View commit details
    Browse the repository at this point in the history

  4. Run cargo fmt

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f1bbddc View commit details
    Browse the repository at this point in the history

  5. Remove unneeded lifetime arguments

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ad15237 View commit details
    Browse the repository at this point in the history

  6. Rename trait: FromBytesWithEncoding to DecodeWithEncoding

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e3b1b6f View commit details
    Browse the repository at this point in the history

  7. Remove more unneeded lifetimes

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    24cc552 View commit details
    Browse the repository at this point in the history

  8. Add DeserializerAdapter::transform_deserialized function 

    Enables us to provide a default implementation for `from_bytes_seed`.
    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1bb6c14 View commit details
    Browse the repository at this point in the history

  9. Add CDR deserializer variant with seed

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    6c4dd82 View commit details
    Browse the repository at this point in the history

  10. Don't require specific error type for seed

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    829df14 View commit details
    Browse the repository at this point in the history

  11. Implement try_take_one_seed

    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ae4f75a View commit details
    Browse the repository at this point in the history

  12. Implement an async stream with seed support 

    Based on cloning the seed.
    @phil-opp
    phil-opp committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a601fdc View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Rename DecodeWithEncoding trait to Decode

    @phil-opp
    phil-opp committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    052a609 View commit details
    Browse the repository at this point in the history

  2. Improve docs and rename: Use 'decoder' instead of 'seed'

    @phil-opp
    phil-opp committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    dd6645a View commit details
    Browse the repository at this point in the history

  3. Fix clippy warning

    @phil-opp
    phil-opp committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    93ef8e6 View commit details
    Browse the repository at this point in the history

  4. Format using nightly rustfmt

    @phil-opp
    phil-opp committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    cbf0d4f View commit details
    Browse the repository at this point in the history

  5. Fix one more clippy suggestion

    @phil-opp
    phil-opp committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fae9fcf View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Merge branch 'main' into deserialize-seed-2

    @phil-opp
    phil-opp committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d543845 View commit details
    Browse the repository at this point in the history

  2. Add Clone requirement to decoder for try_take_one

    @phil-opp
    phil-opp committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4e8e37d View commit details
    Browse the repository at this point in the history