Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency issue #4

Open
eprothro opened this issue Aug 9, 2013 · 15 comments
Open

dependency issue #4

eprothro opened this issue Aug 9, 2013 · 15 comments

Comments

@eprothro
Copy link

eprothro commented Aug 9, 2013

FYI:

Resolving dependencies...
Bundler could not find compatible versions for gem "jquery-ui-rails":
  In Gemfile:
    jquery-ui-sass-rails (~> 4.0.3.0) ruby depends on
      jquery-ui-rails (= 4.0.3) ruby

    jquery-ui-rails (4.0.4)

Is this = dependency intentional?

@jhilden
Copy link
Owner

jhilden commented Aug 14, 2013

Hey @eprothro,
yes this = dependency is intentional to make sure that the 2 gems work correctly together. You should only put jquery-ui-sass-rails in your Gemfile, since that will already pull in jquery-ui-rails in the correct version.

I tried to adjust the README accordingly: 4ec306b Please let me know (or make a PR) if I can make it even clearer.

@eprothro
Copy link
Author

Thanks very much for the reply and the timely doc update, very helpful and
clear!

Only out of curiosity, would a ~> or an explicit >= and < make more
sense to allow for a little more flexibility to allow users access to
bugfixes or minor updates in the jquery-ui-rails dependency without
having to wait for you to update to a new version?

Thanks again!

-Evan Prothro
Sent from my mobile

On Aug 14, 2013, at 2:23 AM, Jakob Hilden [email protected] wrote:

Hey @eprothro https://github.com/eprothro,
yes this = dependency is intentional to make sure that the 2 gems work
correctly together. You should only put jquery-ui-sass-rails in your
Gemfile, since that will already pull in jquery-ui-rails in the correct
version.

I tried to adjust the README accordingly:
4ec306bhttps://github.com/jhilden/jquery-ui-sass-rails/commit/4ec306be7c7762f3a20ca3e3d2743bda29c888c8Please
let me know (or make a PR) if I can make it even clearer.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/4#issuecomment-22618979
.

@mattsjohnston
Copy link

I'm having a dependency conflict between this and Activeadmin, which requires jquery-ui-rails 4.1.0. I'd second the request to get a more flexible dependency if possible.

@aaronstarkey
Copy link

+1
i'm also having a dependency conflict with rails_admin.

@eprothro
Copy link
Author

@jhilden if you reconsider, I'm happy to submit a PR.

Personally, if you're very concerned about version alignment, I think a post-bundle or on-init warning might be more appropriate than the explicit version constraint.

@jhilden
Copy link
Owner

jhilden commented Mar 13, 2014

does that already help? 13eabf0

can you describe the exact depency conflict (with all version numbers)

I would be very open to a PR, how would you solve the issue?

@eprothro
Copy link
Author

That is better and would have fixed my case, yes.

I assumed that unless we explicitly know a future version breaks something, that >= is the best practice. However, @jhilden you know more about what the potential risks are here than I do, so I defer.

@mattsjohnston can you provide more specifics about your conflict?

@EntilZha
Copy link

I am getting this error since jquery-ui-rails is on 4.1 and this package is on 4.0.2. Is there an easy fix?

@jhilden
Copy link
Owner

jhilden commented Jun 10, 2014

This gem will need to be updated. I can work on it as soon as I have some time, but any help/PR in the meantime would be highly appreciated.

@cantonyselim
Copy link

Have there been any updates on this? I am having trouble installing ActiveAdmin

@stephenjlovell
Copy link

Am also still seeing this issue with rails_admin (>= 0)

@jhilden
Copy link
Owner

jhilden commented Aug 16, 2015

I'm sorry, but I'm not actively maintaining this gem anymore. But PRs and potential new maintainers are very welcome.

@cantonyselim
Copy link

@stephenjlovell I can't help you with rails admin but I played with the gem spec on both this gem and activeadmin and got them to play nice. If you are interested check out the forks here

@jhilden
Copy link
Owner

jhilden commented Aug 19, 2015

As I said, PRs are always welcome.

@stephenjlovell
Copy link

@cantonyselim thanks for the link, will check it out. I'm building a survey automation app and experimenting with a few options for the back end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants