Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 5 #12712

Closed
1 task done
mraible opened this issue Oct 11, 2020 · 12 comments · Fixed by #13615
Closed
1 task done

Upgrade to webpack 5 #12712

mraible opened this issue Oct 11, 2020 · 12 comments · Fixed by #13615
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ javascript Pull requests that update Javascript code theme: dependencies Pull requests that update a dependency file theme: react theme: vue $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mraible
Copy link
Contributor

mraible commented Oct 11, 2020

Overview of the feature request

Released today! https://twitter.com/thelarkinn/status/1315062117221851136?s=21

Motivation for or Use Case

It will make micro frontends easier to implement.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@DanielFran DanielFran added area: enhancement 🔧 javascript Pull requests that update Javascript code theme: dependencies Pull requests that update a dependency file theme: front and removed area: triage theme: undefined labels Oct 11, 2020
@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Oct 12, 2020
@mraible
Copy link
Contributor Author

mraible commented Oct 12, 2020

I don't think this will be easy, so I'm assigning a bug bounty to this. I can increase the amount if requested.

@mshima
Copy link
Member

mshima commented Oct 13, 2020

I will be working on this.

@mshima
Copy link
Member

mshima commented Oct 16, 2020

@mraible @angular/cli@10 will not provide support for webpack@5 angular/angular-cli#17555 (comment).
@angular/cli@10 has a peer dependency on webpack@4, so it will conflict with #12747.

At angular front, webpack@5 will happen by default with angular@11 only.
Don't have time to look at others frameworks now.

@gmarziou
Copy link
Contributor

Once #10624 is complete, this would come "for free"

@artemis-bot
Copy link

@mshima is there any progress on this issue so far? We would also gladly transition to Webpack 5 with our jhipster application, as soon as Angular 11 is available, which seems to be in the near future. RC1 is already available.

@mshima
Copy link
Member

mshima commented Oct 31, 2020

@artemis-bot there is nothing we can do for angular in our side right now.
We need to wait webpack 5 support from dependencies like https://www.npmjs.com/package/@angular-builders/custom-webpack.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@pascalgrimaud
Copy link
Member

still in todo list

@krusche
Copy link

krusche commented Dec 14, 2020

any news here?

@mraible mraible added $500 https://www.jhipster.tech/bug-bounties/ and removed $200 https://www.jhipster.tech/bug-bounties/ labels Dec 29, 2020
@Tcharl
Copy link
Contributor

Tcharl commented Jan 14, 2021

@angular-builders/custom-webpack 11 has been published 18 days ago and it seems to have fixed the webpack-5 issue

@mshima
Copy link
Member

mshima commented Jan 14, 2021

At angular part, we should wait for angular-cli to support webpack@5.
Currently the only way is to use yarn resolution and force it.
IFAIK our angular implementation is ready.
Dependencies without webpack@5 is angular-cli and ng-bootstrap.

@mshima
Copy link
Member

mshima commented Jan 20, 2021

Angular how to added at #13642 (comment)

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ javascript Pull requests that update Javascript code theme: dependencies Pull requests that update a dependency file theme: react theme: vue $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants