[angular] Switch to Angular CLI #10624

wmarques · 2019-10-15T15:20:53Z

As discussed, given the opportunities offered by the Angular CLI, we can now extend their config with ours so IMO we should move into Angular CLI.

This offers some advantages:

Less config files
Less dependencies
Enjoy the benefits of Angular CLI (further optimisations, differential loading)

We could even go further with the Angular CLI schematics, for example we could do an Entity schematic to generate an entity page.

Still Todo:

Compare bundles (check drawbacks)
Remove old dependencies / useless files
ng test Jest support
PWA support

Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

DanielFran · 2019-12-14T10:52:03Z

@wmarques Can you fix conflicts?
Would be awesome to have it ready for next release.

wmarques · 2019-12-20T09:50:32Z

@DanielFran I think it will be for the v7, I want to test this well and to check if we don't lost performances

qmonmert · 2020-01-14T10:07:31Z

generators/client/templates/angular/package.json.ejs

@@ -60,6 +60,8 @@
    "zone.js": "0.10.2"
  },
  "devDependencies": {
+    "@angular-builders/custom-webpack": "^8.2.0",


"^8.2.0" => "8.2.0"

qmonmert · 2020-01-14T10:07:51Z

generators/client/templates/angular/package.json.ejs

@@ -60,6 +60,8 @@
    "zone.js": "0.10.2"
  },
  "devDependencies": {
+    "@angular-builders/custom-webpack": "^8.2.0",
+    "@angular-devkit/build-angular": "^0.803.3",


"^0.803.3" => "0.803.3"

qmonmert · 2020-01-14T10:08:34Z

generators/client/templates/angular/src/main/webapp/app/polyfills.ts.ejs

@@ -18,4 +18,4 @@
 -%>
 import 'core-js/proposals/reflect-metadata';
 import 'zone.js/dist/zone';
-require('../manifest.webapp');
+//require('../manifest.webapp');


so you can remove this line ?

mraible · 2020-01-17T05:40:18Z

This PR needs a rebase to fix conflicts.

wmarques · 2020-01-17T17:18:18Z

Yep I'll work on it during the month

CLAassistant · 2020-04-20T12:07:20Z

All committers have signed the CLA.

pascalgrimaud · 2020-05-30T09:57:35Z

@wmarques : what is the state of your PR ? The original ticket is opened for too long (8 months)

qmonmert · 2020-08-28T09:03:43Z

generators/client/templates/angular/tsconfig.app.json.ejs

@@ -18,5 +18,5 @@
 -%>
 {
    "extends": "./tsconfig.json",
-    "files": ["<%= MAIN_SRC_DIR %>app/app.main.ts"]
+    "files": ["<%= MAIN_SRC_DIR %>app/app.main.ts","<%= MAIN_SRC_DIR %>app/polyfills.ts"]


"<%= MAIN_SRC_DIR %>app/app.main.ts","<%= MAIN_SRC_DIR %>app/polyfills.ts"
=>
"<%= MAIN_SRC_DIR %>app/app.main.ts", "<%= MAIN_SRC_DIR %>app/polyfills.ts"
😇

mshima

Should webpack.(common|prod|dev).js be removed?

test/utils/expected-files.js

generators/client/templates/angular/tsconfig.spec.json.ejs

generators/client/templates/angular/webpack/proxy.conf.js.ejs

generators/client/templates/angular/angular.json.ejs

wmarques · 2020-10-19T11:56:24Z

Thanks alot @mshima for your review ! I'll do this tomorrow in the afternoon, hope we can merge this asap then

mshima · 2020-10-19T12:05:48Z

Thanks alot @mshima for your review ! I'll do this tomorrow in the afternoon, hope we can merge this asap then

Saw yesterday that this is almost ready.
Great work.

mshima · 2020-10-20T23:11:51Z

@wmarques do you want some help finishing this PR?

wmarques · 2020-10-20T23:17:36Z

No thanks I'll apply your comments tomorrow, I was quite busy today 🙁

DanielFran · 2020-10-24T10:24:23Z

@wmarques Can you fix the conflicts.
There is too much changes in main repo, and this PR is almost done and should be merged as soon as you fix last comments 😊

wmarques · 2020-10-24T16:15:51Z

@DanielFran Working on it !

wmarques · 2020-10-24T16:45:32Z

I'll fix this tomorrow, sorry I won't have time tonight 😢

pascalgrimaud · 2020-10-25T21:31:03Z

@wmarques : if the CI is green and if you feel confident, go ahead and merge this. It will avoid some conflict and we can still do post review

test/needle-api/needle-client-webpack.spec.js

wmarques · 2020-10-26T00:28:23Z

Finally ! Thanks guys, that was quite a journey 😄
I'll keep an eye on issues and I'll provide some PRs to improve it (like the eslint-plugin as suggested by @kaidohallik)

kaidohallik · 2020-10-26T04:22:19Z

The final result LGTM, thanks for your hard work @wmarques !

gmarziou · 2020-10-26T10:52:18Z

Great work!

I also think the doc and the generated README.md should be updated.

wmarques · 2020-10-26T13:11:07Z

@gmarziou you're right I'll work on it tonight

wmarques added area: enhancement 🔧 theme: angular labels Oct 15, 2019

wmarques changed the title ~~Switch to Angular CLI~~ WIP Switch to Angular CLI Oct 15, 2019

wmarques force-pushed the add-angular-cli branch from b38d226 to dd166b2 Compare October 15, 2019 15:48

DanielFran added the status: work in progress label Nov 6, 2019

wmarques added the v7 label Dec 20, 2019

qmonmert reviewed Jan 14, 2020

View reviewed changes

wmarques force-pushed the add-angular-cli branch from dd166b2 to 91cfa25 Compare March 17, 2020 12:36

qmonmert reviewed Aug 28, 2020

View reviewed changes

wmarques force-pushed the add-angular-cli branch from ff4494d to f1e6829 Compare August 29, 2020 20:14

mshima changed the title ~~WIP Switch to Angular CLI~~ [angular] WIP Switch to Angular CLI Aug 29, 2020

wmarques force-pushed the add-angular-cli branch from 867d129 to fc52ded Compare August 30, 2020 18:25

wmarques force-pushed the add-angular-cli branch from fc52ded to a096e40 Compare September 14, 2020 16:30

pascalgrimaud changed the base branch from master to main October 11, 2020 20:18

wmarques force-pushed the add-angular-cli branch from a096e40 to 5a22159 Compare October 13, 2020 14:05

gmarziou mentioned this pull request Oct 16, 2020

Upgrade to webpack 5 #12712

Closed

1 task

mshima requested changes Oct 19, 2020

View reviewed changes

mshima mentioned this pull request Oct 20, 2020

Images referenced by css are not shown any more in Angular #12803

Closed

1 task

wmarques force-pushed the add-angular-cli branch 4 times, most recently from f261ff7 to 3410c88 Compare October 25, 2020 21:26

DanielFran requested review from mshima and kaidohallik October 25, 2020 21:30

mshima requested changes Oct 25, 2020

View reviewed changes

test/needle-api/needle-client-webpack.spec.js Outdated Show resolved Hide resolved

test/needle-api/needle-client-webpack.spec.js Outdated Show resolved Hide resolved

wmarques force-pushed the add-angular-cli branch from 3410c88 to c8eedb6 Compare October 25, 2020 22:13

angular: Switch to Angular CLI

805e5cc

wmarques force-pushed the add-angular-cli branch from c8eedb6 to 805e5cc Compare October 25, 2020 23:11

wmarques changed the title ~~[angular] WIP Switch to Angular CLI~~ [angular] Switch to Angular CLI Oct 25, 2020

wmarques removed the status: work in progress label Oct 25, 2020

wmarques merged commit d2f82e3 into jhipster:main Oct 26, 2020

wmarques deleted the add-angular-cli branch October 26, 2020 00:27

This was referenced Oct 27, 2020

Update Angular page jhipster/jhipster.github.io#1025

Merged

[angular] Update Angular README #12869

Merged

This was referenced Nov 19, 2020

[angular] Fix WebSockets in Browsersync #13099

Merged

[angular] Fix some sonar issues #13113

Merged

[angular] Fix vendor and update @angular-builders #13118

Merged

pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[angular] Switch to Angular CLI #10624

[angular] Switch to Angular CLI #10624

wmarques commented Oct 15, 2019 •

edited

Loading

DanielFran commented Dec 14, 2019

wmarques commented Dec 20, 2019

qmonmert Jan 14, 2020

qmonmert Jan 14, 2020

qmonmert Jan 14, 2020

mraible commented Jan 17, 2020

wmarques commented Jan 17, 2020

CLAassistant commented Apr 20, 2020 •

edited

Loading

pascalgrimaud commented May 30, 2020

qmonmert Aug 28, 2020

mshima left a comment

wmarques commented Oct 19, 2020

mshima commented Oct 19, 2020

mshima commented Oct 20, 2020

wmarques commented Oct 20, 2020

DanielFran commented Oct 24, 2020

wmarques commented Oct 24, 2020

wmarques commented Oct 24, 2020

pascalgrimaud commented Oct 25, 2020

wmarques commented Oct 26, 2020

kaidohallik commented Oct 26, 2020

gmarziou commented Oct 26, 2020 •

edited

Loading

wmarques commented Oct 26, 2020

[angular] Switch to Angular CLI #10624

[angular] Switch to Angular CLI #10624

Conversation

wmarques commented Oct 15, 2019 • edited Loading

DanielFran commented Dec 14, 2019

wmarques commented Dec 20, 2019

qmonmert Jan 14, 2020

Choose a reason for hiding this comment

qmonmert Jan 14, 2020

Choose a reason for hiding this comment

qmonmert Jan 14, 2020

Choose a reason for hiding this comment

mraible commented Jan 17, 2020

wmarques commented Jan 17, 2020

CLAassistant commented Apr 20, 2020 • edited Loading

pascalgrimaud commented May 30, 2020

qmonmert Aug 28, 2020

Choose a reason for hiding this comment

mshima left a comment

Choose a reason for hiding this comment

wmarques commented Oct 19, 2020

mshima commented Oct 19, 2020

mshima commented Oct 20, 2020

wmarques commented Oct 20, 2020

DanielFran commented Oct 24, 2020

wmarques commented Oct 24, 2020

wmarques commented Oct 24, 2020

pascalgrimaud commented Oct 25, 2020

wmarques commented Oct 26, 2020

kaidohallik commented Oct 26, 2020

gmarziou commented Oct 26, 2020 • edited Loading

wmarques commented Oct 26, 2020

wmarques commented Oct 15, 2019 •

edited

Loading

CLAassistant commented Apr 20, 2020 •

edited

Loading

gmarziou commented Oct 26, 2020 •

edited

Loading