Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images referenced by css are not shown any more in Angular #12803

Closed
1 task done
kaidohallik opened this issue Oct 20, 2020 · 1 comment · Fixed by #12804
Closed
1 task done

Images referenced by css are not shown any more in Angular #12803

kaidohallik opened this issue Oct 20, 2020 · 1 comment · Fixed by #12804

Comments

@kaidohallik
Copy link
Contributor

kaidohallik commented Oct 20, 2020

Overview of the issue

Images referenced in css are not shown any more. For example JHipster family member in home page and JHipster tie in navbar.

Motivation for or Use Case

Images referenced in css should be shown.

Reproduce the error

Generate Angular app with current master and start app and see that images in homepage and navbar are missing.

Related issues

This is regression from css-loader version upgrade (from version 3 to version 5) PR #12755 - before that change images in css are working.

Suggest a Fix

Look at css-loader release notes https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md v4 and v5 breaking changes sections and try to understand what needs to be changed in JHipster.

JHipster Version(s)
[email protected] c:\projects\teest\jhipster7
`-- [email protected]

JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "blueprints": [],
    "otherModules": [],
    "applicationType": "monolith",
    "reactive": false,
    "baseName": "jhipster7",
    "jhipsterVersion": "6.10.4",
    "skipClient": false,
    "skipServer": false,
    "skipUserManagement": false,
    "skipCheckLengthOfIdentifier": false,
    "skipFakeData": false,
    "jhiPrefix": "jhi",
    "entitySuffix": "",
    "dtoSuffix": "DTO",
    "clientPackageManager": "npm",
    "testFrameworks": ["cypress"],
    "pages": [],
    "creationTimestamp": 1603213069799,
    "promptValues": {
      "packageName": "com.mycompany.myapp",
      "nativeLanguage": "et"
    },
    "serviceDiscoveryType": false,
    "authenticationType": "jwt",
    "packageName": "com.mycompany.myapp",
    "serverPort": "8080",
    "cacheProvider": "ehcache",
    "enableHibernateCache": true,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "postgresql",
    "buildTool": "gradle",
    "serverSideOptions": [],
    "websocket": false,
    "searchEngine": false,
    "messageBroker": false,
    "enableSwaggerCodegen": false,
    "clientFramework": "angularX",
    "clientTheme": "none",
    "enableTranslation": true,
    "nativeLanguage": "et",
    "packageFolder": "com/mycompany/myapp",
    "jwtSecretKey": "YourJWTSecretKeyWasReplacedByThisMeaninglessTextByTheJHipsterInfoCommandForObviousSecurityReasons",    "clientThemeVariant": "primary",
    "useSass": true,
    "languages": ["et", "en", "ru"]
  }
}
JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory

ls: no such file or directory: .jhipster/*.json

JDL entity definitions

Environment and Tools

openjdk version "11.0.8" 2020-07-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+10, mixed mode)

git version 2.29.0.windows.1

node: v12.18.4

npm: 6.11.3

yeoman: 3.1.1

yarn: 1.22.4

Docker version 19.03.13, build 4484c46d9d

docker-compose version 1.27.4, build 40524192

Browsers and Operating System

Windows

  • Checking this box is mandatory (this is just to show you read everything)
@mshima
Copy link
Member

mshima commented Oct 20, 2020

We should downgrade if we need this fixed, otherwise we should wait for #10624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants