Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to npm 7. #13060

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Switch to npm 7. #13060

merged 1 commit into from
Jan 23, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 16, 2020 •
edited
Loading

Fixes #12747.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

DanielFran
DanielFran approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few changes to avoid to update workflows with minor changes version of node and npm

.github/workflows/angular.yml Outdated
@@ -73,6 +73,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [14.15.x]

.github/workflows/angular.yml Outdated
@@ -73,6 +73,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
npm_version: [7.0.11]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [7.0.x]

.github/workflows/generator.yml Outdated
@@ -35,11 +35,14 @@ jobs:
matrix:
node_version: [14.15.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [14.15.x]

.github/workflows/generator.yml Outdated
@@ -35,11 +35,14 @@ jobs:
matrix:
node_version: [14.15.0]
os: [ubuntu-20.04]
npm_version: [7.0.11]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [7.0.x]

.github/workflows/incremental-changelog.yml Outdated
@@ -70,6 +70,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [14.15.x]

.github/workflows/react.yml Outdated
@@ -73,6 +73,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
npm_version: [7.0.11]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [7.0.x]

.github/workflows/vue.yml Outdated
@@ -73,6 +73,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [14.15.x]

.github/workflows/vue.yml Outdated
@@ -73,6 +73,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
npm_version: [7.0.11]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [7.0.x]

.github/workflows/webflux.yml Outdated
@@ -72,6 +72,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [14.15.x]

.github/workflows/webflux.yml Outdated
@@ -72,6 +72,7 @@ jobs:
fail-fast: false
matrix:
node_version: [14.15.0]
npm_version: [7.0.11]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to [7.0.x]

@mshima
Copy link
Member Author

mshima commented Nov 17, 2020

@DanielFran not sure npm install [email protected] works, should be npm install npm@~7.0.0.

Shouldn’t we stick with fixed version to match npm used at maven frontend?

generator-jhipster/generators/generator-constants.js

Lines 33 to 34 in 2419625

const NODE_VERSION = '14.15.0';
const NPM_VERSION = '6.14.8';

@DanielFran
Copy link
Member

It was just a suggestion... No problem to keep it like that.

@mshima mshima marked this pull request as draft November 23, 2020 16:17
@pascalgrimaud
Copy link
Member

yes, we should use an exact version in the CI, to match with const NODE_VERSION = '14.15.0'

@mshima mshima marked this pull request as ready for review December 11, 2020 17:24
@mshima
Copy link
Member Author

mshima commented Dec 11, 2020

Looks like most of backward incompatibilities was fixed.

@mraible
Copy link
Contributor

mraible commented Jan 22, 2021

I've been using npm 7 for the last 24 hours with JHipster 7 and haven't experienced any issues.

$ npm --version
7.4.2

@mshima
Copy link
Member Author

mshima commented Jan 22, 2021

Problems happens when mixing full build with without webapp profile.
That will make node_modules/lock been switched from 6 <-> 7.
A full build installs a npm 6 locally and uses it.

@pascalgrimaud
Copy link
Member

if it's stable enough, then we could have it for final v7 release

@mshima
Copy link
Member Author

mshima commented Jan 23, 2021

@pascalgrimaud yep it's working great IMO, better then npm 6.

@pascalgrimaud
Copy link
Member

Ok nice @mshima ! I'll test npm7 this Monday

Can you resolve conflicts plz? So this PR can be merged

@pascalgrimaud pascalgrimaud merged commit df2ae0b into jhipster:main Jan 23, 2021
@mshima mshima deleted the skip_ci_npm7 branch January 23, 2021 23:21
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielFran DanielFran DanielFran approved these changes

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

@jdubois jdubois Awaiting requested review from jdubois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Add support to npm 7.
4 participants
@mshima @DanielFran @pascalgrimaud @mraible