-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small performance improvements on mobile devices #1382
Conversation
✅ Deploy Preview for jhipster-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I tried running the current site through https://pagespeed.web.dev: Then, I tried the preview for this PR: I'm not sure why the SEO went down. Maybe PageSpeed gets different information from Netlify vs. GitHub pages? |
The main image on the homepage looks a little grainy with this PR. The current site has a much more crisp image, at least on my MacBook Pro. |
@mraible Could you please check the latest changes? |
The image looks better. Performance is 51 on mobile and 70 on desktop. I was going to test our documentation archives to see what the old site's performance was. That's when I discovered our documentation archives are still using files from the main site. For example, see https://www.jhipster.tech/documentation-archive/v8.7.0/. I've entered a new issue to track this. jhipster/generator-jhipster#27315 |
In preview mode Netlify added some third party scripts and this lowered the rating, in production version the rating should be higher. |
Related to jhipster/generator-jhipster#27122