Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small performance improvements on mobile devices #1382

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

SvMak
Copy link
Contributor

@SvMak SvMak commented Sep 12, 2024

  • replaced hero image from svg to webp;
  • reducing DOM size.

Related to jhipster/generator-jhipster#27122

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for jhipster-site ready!

Name Link
🔨 Latest commit 785e9fd
🔍 Latest deploy log https://app.netlify.com/sites/jhipster-site/deploys/66e9ea993c3c5e00089a119b
😎 Deploy Preview https://deploy-preview-1382--jhipster-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mraible
Copy link
Collaborator

mraible commented Sep 13, 2024

I tried running the current site through https://pagespeed.web.dev:

Screenshot 2024-09-12 at 18 26 42

Then, I tried the preview for this PR:

Screenshot 2024-09-12 at 18 27 36

I'm not sure why the SEO went down. Maybe PageSpeed gets different information from Netlify vs. GitHub pages?

@SvMak
Copy link
Contributor Author

SvMak commented Sep 13, 2024

Screenshot 2024-09-13 073004

Netlify is set to noindex

@mraible
Copy link
Collaborator

mraible commented Sep 14, 2024

The main image on the homepage looks a little grainy with this PR. The current site has a much more crisp image, at least on my MacBook Pro.

@SvMak SvMak marked this pull request as draft September 14, 2024 17:52
@SvMak SvMak marked this pull request as ready for review September 17, 2024 20:55
@SvMak
Copy link
Contributor Author

SvMak commented Sep 17, 2024

The main image on the homepage looks a little grainy with this PR. The current site has a much more crisp image, at least on my MacBook Pro.

@mraible Could you please check the latest changes?

@mraible
Copy link
Collaborator

mraible commented Sep 18, 2024

The image looks better. Performance is 51 on mobile and 70 on desktop.

https://pagespeed.web.dev/analysis/https-deploy-preview-1382--jhipster-site-netlify-app/oatghbq1ev?form_factor=mobile

I was going to test our documentation archives to see what the old site's performance was. That's when I discovered our documentation archives are still using files from the main site. For example, see https://www.jhipster.tech/documentation-archive/v8.7.0/.

I've entered a new issue to track this. jhipster/generator-jhipster#27315

@SvMak
Copy link
Contributor Author

SvMak commented Sep 18, 2024

The image looks better. Performance is 51 on mobile and 70 on desktop.

https://pagespeed.web.dev/analysis/https-deploy-preview-1382--jhipster-site-netlify-app/oatghbq1ev?form_factor=mobile

In preview mode Netlify added some third party scripts and this lowered the rating, in production version the rating should be higher.

@mraible mraible merged commit ed7ac88 into jhipster:main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants