Skip to content

Commit

Permalink
adding a way to pass additional flags to E2E tests (Azure#1998)
Browse files Browse the repository at this point in the history
  • Loading branch information
Makdaam authored and jhoreman committed May 3, 2022
1 parent 0f224da commit 0f28d4d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ SHELL = /bin/bash
TAG ?= $(shell git describe --exact-match 2>/dev/null)
COMMIT = $(shell git rev-parse --short=7 HEAD)$(shell [[ $$(git status --porcelain) = "" ]] || echo -dirty)
ARO_IMAGE_BASE = ${RP_IMAGE_ACR}.azurecr.io/aro
E2E_FLAGS ?= -test.timeout 180m -test.v -ginkgo.v

# fluentbit version must also be updated in RP code, see pkg/util/version/const.go
FLUENTBIT_VERSION = 1.7.8-1
Expand Down Expand Up @@ -141,7 +142,7 @@ e2e.test:
go test ./test/e2e -tags e2e,codec.safe -c -ldflags "-X github.com/Azure/ARO-RP/pkg/util/version.GitCommit=$(VERSION)" -o e2e.test

test-e2e: e2e.test
./e2e.test -test.timeout 180m -test.v -ginkgo.v
./e2e.test $(E2E_FLAGS)

test-go: generate build-all validate-go lint-go unit-test-go

Expand Down
2 changes: 2 additions & 0 deletions docs/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ E2e tests can also be run locally as follows:
- Run the `make test-e2e` target
- Delete the cosmos database, if applicable

You can also modify the flags passed to the e2e.test run by setting the E2E_FLAGS environment variable before running `make test-e2e`.

These steps can be acheived using commands below. Look at the [e2e helper
file](../hack/e2e/run-rp-and-e2e.sh) to understand each of the bash functions
below.
Expand Down

0 comments on commit 0f28d4d

Please sign in to comment.