Restore path-searching logic to fix #107 #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't accept this PR without a test, since there's a high risk I'll revert it in the future by accident. |
|
Quite right. See new version. |
jhthorsen
pushed a commit
that referenced
this pull request
Feb 14, 2019
|
Pretty sure this is fixed together with #105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the commit referred to in #107, the stack was being searched for the last entry that had the
openapi.[op_]pathset, and using that. That commit just used the last one, since an array-ref is always true. This PR restores that logic, which then works correctly with Yancy.