Allows the user to modify navigation header from config.toml #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies config.toml and the masthead_nav.html partial.
jhu247
requested changes
Feb 13, 2019
There was a problem hiding this comment.
Great work @theorangepotato and pardon the inactivity on my part.
Looks good, but can you please rename variable names to k and v to remain consistent throughout the project. I will eventually add PR guidelines to the readme. Thanks!
* Changes layouts/partials/masthead_nav.html such that $i -> $k and $e -> $v * Changes params.menu.name -> params.menu.label
|
I also felt like calling the link text |
|
Good call. Please change |
… for consistency.
|
Good point. I have implemented these changes. Let me know if you think of anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the request from #11 to allow the user to modify the header navigation links from the
config.tomlfile.