Proposed fix : Disallow replacing nodes with themselves #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a test for this edge case closes jhy#1843
|
Thanks for this correction 💯 |
|
@FanJups My apologies, I typed the wrong issue number - this is unrelated to your problem of self closing tags. Sorry for getting your hopes up lol |
|
all right lol |
jhy
reviewed
Jan 5, 2023
| * @param message Error message to use if the objects are the same | ||
| * @throws IllegalArgumentException if the objects are the same | ||
| */ | ||
| public static void notStrictlyEqual(Object a, Object b, String message) { |
There was a problem hiding this comment.
Personally, I would call this method something like "NotSameObject". To make it clearer that it's an identity check.
|
Thanks for the PR and the bug report. I think that it would be better to make this a no-op vs a validation error. It follows closer to the developer's intent (whatever that was) and is not surprising. I.e., if And then the new validator is not required either. |
jhy
requested changes
Jan 6, 2023
|
I implemented this with 9bb07d2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1843 :
Node.replaceWithdeletes siblings and creates an invalid state if a node is replaced with itself.Proposed changes :
ValidationExceptionjust as any other invalid parameter would.