Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Java's UncheckedIOException. #1989

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

Isira-Seneviratne
Copy link
Contributor

No description provided.

@jhy
Copy link
Owner

jhy commented Sep 12, 2023

This is failing because we currently have

<excludes>
  <exclude>@java.lang.Deprecated</exclude>
</excludes>

configured in japicmp. This allows the previously deprecated methods (between 1.16.1 and removed in 1.16.2) to not blow up. But I can't see a way to configure japicmp to allow this to be marked deprecated while that exclude is on -- it makes the class invisible and therefore looks like a removal. So I think we need to pick it up after the next release.

Also I think we should change the signature to

public class UncheckedIOException extends java.io.UncheckedIOException 

(and throw the extended not base version) for a release. That way if anyone is explicitly catching this exception, the current code will still work and they have an opportunity to migrate.

The internal throws will continue to throw the internal UncheckedIOException shim, which now extends the java.io version. But the declared / visible throws are java.io. So in the next release we can mark Deprecated, and then remove subsequently.
@jhy jhy added this to the 1.16.2 milestone Sep 12, 2023
@jhy jhy merged commit 780f5f2 into jhy:master Sep 12, 2023
12 checks passed
jhy added a commit that referenced this pull request Sep 12, 2023
@jhy jhy added the fixed label Sep 12, 2023
@Isira-Seneviratne Isira-Seneviratne deleted the UncheckedIOException branch December 30, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants