Bump minimum Android API level to 21 #2173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Sniffer-API-21
branch
2 times, most recently
from
798c5c1
to
1f91749
Compare
Isira-Seneviratne
force-pushed
the
Sniffer-API-21
branch
2 times, most recently
from
0a36a35
to
3151ea5
Compare
|
Is there anything other that might be useful other than StandardCharsets? That doesn't really make any difference from my POV, being that we statically initialize UTF-8 anyway at startup. I get that the usage is very low % wise, but I don't see a reason to remove support just because? |
|
There's also try-with-resources. |
|
OK, try-with-resources will be good to have. I have marked this for the 1.19.1 milestone (vs 1.18.2), as I feel that the change warrants being in a major bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android versions below 5.0 (API level 21) are obsolete these days. This change would allow the use of features such as
StandardCharsets, which is available on Android 4.4 (API level 19) and higher.This PR also changes one Sniffer dependency to Gummy Bears, which has support for desugaring.