Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, replaced the choice of the key to get #290

Merged
merged 9 commits into from
Jun 15, 2018
Merged

Fix, replaced the choice of the key to get #290

merged 9 commits into from
Jun 15, 2018

Conversation

skar404
Copy link
Contributor

@skar404 skar404 commented Jun 13, 2018

No description provided.

@skar404
Copy link
Contributor Author

skar404 commented Jun 13, 2018

#285

@jiaaro
Copy link
Owner

jiaaro commented Jun 13, 2018

Does this account for the change in format mentioned in #285 ?

If not, maybe it'd be easier to get the json formatted output from ffprobe/avprobe?

@skar404
Copy link
Contributor Author

skar404 commented Jun 13, 2018

@jiaaro This is a bug fix from: https://github.com/jiaaro/pydub/blob/master/pydub/utils.py#L284, (because it's not else, for this reason sample_fmt may not exist),

Unfortunately not so well while I understand as utils.py works c ffprobe/avprobe, for this reason did not want to climb there.

Sorry, but the text was translated from the Russian language, so I attach the original:

Это исправления ошибки со строки: https://github.com/jiaaro/pydub/blob/master/pydub/utils.py#L284, (потому как не else, по этой причине sample_fmt может не существовать )
К сожалению пока еще не очень хорошо пока понимаю как utils.py работает c ffprobe/avprobe, по этой причине не хотел туда лезть.

Set default value  in sample_fmt, bits_per_sample or bits_per_raw_sample
@skar404
Copy link
Contributor Author

skar404 commented Jun 14, 2018

@jiaaro on macOS, almost all tests fall
Log: https://gist.github.com/skar404/c31339794d79eca2dfe1c78d68d253ab

Output from ffmpeg/avlib:

b"0:0: Audio: mp3\n      32000 Hz, 2 channels, s16p, 96 kb/s\nUnknown encoder 'pcm_s0le'\n")
avconv version 12.3, Copyright (c) 2000-2018 the Libav developers
  built on Jun 13 2018 20:17:38 with Apple LLVM version 9.1.0 (clang-902.0.39.2)
Guessed Channel Layout for Input Stream #0.0 : stereo
Input #0, mp3, from '/Users/users/project/pydub/test/data/test1.mp3':
  Metadata:
    encoder         : Lavf55.12.100
  Duration: 00:00:10.04, start: 0.000000, bitrate: 96 kb/s
    Stream #0:0: Audio: mp3
      32000 Hz, 2 channels, s16p, 96 kb/s
Unknown encoder 'pcm_s0le'"

@skar404
Copy link
Contributor Author

skar404 commented Jun 14, 2018

updated the parser format for macOS.

@skar404 skar404 mentioned this pull request Jun 14, 2018
@jiaaro jiaaro merged commit e7a8780 into jiaaro:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants