Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter prefix to import #42

Closed
wants to merge 1 commit into from
Closed

Add flutter prefix to import #42

wants to merge 1 commit into from

Conversation

jiahaog
Copy link
Owner

@jiahaog jiahaog commented Dec 4, 2023

This keeps things consistent with other imports and fixes the internal breakage (b/314687390).

While the build system here is able to handle imports both with and without the flutter prefix, the internal mechanism that rewrites these imports is currently unable to handle the latter case.

(The import modified here was introduced in flutter#48478)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

This keeps things consistent with other imports and fixes the internal breakage (b/314687390).

While the build system here is able to handle imports both with and without the `flutter` prefix, the internal mechanism that rewrites these imports is currently unable to handle the latter case.
@jiahaog jiahaog marked this pull request as ready for review December 4, 2023 02:19
@jiahaog jiahaog closed this Dec 4, 2023
@jiahaog jiahaog deleted the jiahaog-patch-3 branch December 4, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant