Merge pull request #19 from alzimmermsft/AzStorage_Blobs_Verify_Tests

Fix linting error reporting and cleaned up more tests
jianghaolu · Jun 28, 2019 · e3a8e37 · e3a8e37
2 parents 1343f5e + 25ed916
commit e3a8e37
Show file tree

Hide file tree

Showing 7 changed files with 118 additions and 854 deletions.
diff --git a/storage/client/pom.xml b/storage/client/pom.xml
@@ -127,4 +127,35 @@
       </plugin>
     </plugins>
   </build>
+
+  <reporting>
+    <plugins>
+      <!-- Now that all checkstyle issues have been resolved, override the
+             default behavior to make checkstyle fail on error and violation. -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <configuration>
+          <failsOnError>false</failsOnError>
+          <failOnViolation>false</failOnViolation>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-javadoc-plugin</artifactId>
+        <configuration>
+          <failOnError>false</failOnError>
+          <failOnWarnings>false</failOnWarnings>
+        </configuration>
+      </plugin>
+
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <configuration>
+          <failOnError>false</failOnError>
+        </configuration>
+      </plugin>
+    </plugins>
+  </reporting>
 </project>
diff --git a/storage/client/src/test/java/com/azure/storage/blob/AppendBlobAPITest.groovy b/storage/client/src/test/java/com/azure/storage/blob/AppendBlobAPITest.groovy
@@ -144,19 +144,6 @@ class AppendBlobAPITest extends APISpec {
         null     | null       | null        | null         | garbageLeaseID
     }
 
-    /*def "Create context"() {
-        setup:
-        def pipeline = HttpPipeline.build(getStubFactory(getContextStubPolicy(201, AppendBlobCreateHeaders)))
-
-        bu = bu.withPipeline(pipeline)
-
-        when:
-        bu.create(null, null, null, defaultContext)
-
-        then:
-        notThrown(RuntimeException)
-    }*/
-
     def "Append block defaults"() {
         setup:
         Response<AppendBlobItem> appendResponse = bu.appendBlock(defaultInputStream.get(), defaultDataSize)
@@ -191,6 +178,7 @@ class AppendBlobAPITest extends APISpec {
         data                        | dataSize            | exceptionType
         null                        | defaultDataSize     | NullPointerException
         defaultInputStream.get()    | defaultDataSize + 1 | IndexOutOfBoundsException
+        // This doesn't error as it isn't reading the entire stream which is valid in the new client
         //defaultInputStream.get()    | defaultDataSize - 1 | StorageException
     }
 
@@ -288,19 +276,6 @@ class AppendBlobAPITest extends APISpec {
         thrown(StorageException)
     }
 
-    /*def "Append block context"() {
-        setup:
-        def pipeline = HttpPipeline.build(getStubFactory(getContextStubPolicy(201, AppendBlobAppendBlockHeaders)))
-
-        bu = bu.withPipeline(pipeline)
-
-        when:
-        bu.appendBlock(defaultFlowable, defaultDataSize, null, defaultContext)
-
-        then:
-        notThrown(RuntimeException)
-    }*/
-
     def "Append block from URL min"() {
         setup:
         cu.setAccessPolicy(PublicAccessType.CONTAINER, null)
@@ -372,20 +347,6 @@ class AppendBlobAPITest extends APISpec {
         thrown(StorageException)
     }
 
-    /*def "Append block from URL context"() {
-        setup:
-        def pipeline = HttpPipeline.build(getStubFactory(getContextStubPolicy(201, AppendBlobAppendBlockFromUrlHeaders)))
-
-        bu = bu.withPipeline(pipeline)
-
-        when:
-        // No service call is made. Just satisfy the parameters.
-        bu.appendBlockFromUrl(bu.toURL(), null, null, null,null, defaultContext)
-
-        then:
-        notThrown(RuntimeException)
-    }*/
-
     @Unroll
     def "Append block from URL destination AC"() {
         setup: