Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SharedKeyCredential #10

Merged

Conversation

alzimmermsft
Copy link
Collaborator

No description provided.

@alzimmermsft alzimmermsft merged commit 6e7aaf1 into jianghaolu:storage-url Jun 21, 2019
jianghaolu pushed a commit that referenced this pull request Sep 3, 2019
…zure#4712)

Batch 2

Rule # 5
Service client methods: All methods that are in a class annotated with @ServiceClient, where the method has a @ServiceMethod annotation, should follow these rules:

Methods names should follow a common vocabulary. Refer to Java spec for this naming pattern https://azure.github.io/azure-sdk/java_design.html.
Method names imply certain rules around expected return type - these should all be validated.
Methods should not have 'Async' added to their method name.
Return types of async and sync clients should be as per guidelines: [this check will be ignored for now since I am still struggling on how to get the Reflection working in the code-quality-check]
Return type for async collection should be of type ? extends PagedFlux
Return type for async single value should be of type ? extends Mono
Return type for sync collection should be of type ? extends PagedIterable
Return type for sync single value should be of type ? extends Response
Rule # 10
'withResponse' naming pattern: All methods annotated with @ServiceMethod that return a Response (or Mono) must have their method name end with 'withResponse'. If the service method does not return a Response or Mono, it must not end with 'withResponse'.

Batch 3

Rule # 1
Context in all the right places: Context should be passed in as an argument to all public methods annotated with @ServiceMethod that return Response in sync clients.

Only in the sync case: E.g. we want this: Public Response getFooWithResponse(int x, int y, Context c)
In the async case, we should check to ensure we have no service methods that take Context!
Rule # 6
Async client should have async = true property set in @ServiceClient annotation

To validate this, if the class has @ServiceClient annotation and if the classname AsyncClient, verify that the async property of @ServiceClient annotation is set to true.
Similarly, if the class has @ServiceClient annotation and if the classname is Client, verify that the async property of @ServiceClient annotation is set to false
Change class Context to be final
jianghaolu pushed a commit that referenced this pull request Mar 31, 2021
* Fix creation of DataFactory pipeline

The error is:
```
java.lang.IllegalArgumentException: Body parameter value must not be null. (parameter #10)
    for method PipelinesService.createRun
	at retrofit2.Utils.methodError(Utils.java:52)
	at retrofit2.Utils.methodError(Utils.java:42)
	at retrofit2.Utils.parameterError(Utils.java:61)
	at retrofit2.ParameterHandler$Body.apply(ParameterHandler.java:408)
	at retrofit2.RequestFactory.create(RequestFactory.java:117)
	at retrofit2.OkHttpCall.createRawCall(OkHttpCall.java:192)
	at retrofit2.OkHttpCall.execute(OkHttpCall.java:175)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:40)
	at retrofit2.adapter.rxjava.CallExecuteOnSubscribe.call(CallExecuteOnSubscribe.java:24)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:48)
	at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.unsafeSubscribe(Observable.java:10327)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:48)
	at rx.internal.operators.OnSubscribeMap.call(OnSubscribeMap.java:33)
	at rx.Observable.subscribe(Observable.java:10423)
	at rx.Observable.subscribe(Observable.java:10390)
	at rx.observables.BlockingObservable.forEach(BlockingObservable.java:111)
```

The parameter #10 is `parameters` which represent request body

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant