Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Allow specifying a custom access token - Track 2 approach #15

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jiasli
Copy link
Owner

@jiasli jiasli commented Aug 1, 2022

A rework of #12:

  • Remove the usage of msrest.authentication.BasicTokenAuthentication
  • Use Track 2 SDK get_token protocol

Instead of monkey-patching get_login_credentials, we make _get_mgmt_service_client support custom credential natively.

But if we implement EnvironmentCredential (Azure#10241), custom credential support may not be necessary since we can combine the logic into EnvironmentCredential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant