-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaflet 1.1.0 #45
Leaflet 1.1.0 #45
Conversation
@@ -17,7 +17,7 @@ | |||
// with the top right corner of the target map. | |||
// The values can be less than 0 or greater than 1. It will sync | |||
// points out of the map. | |||
L.Util.offsetHelper = function (ratioRef, ratioTgt) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a function to L.Util does not work in my Ubuntu Chrome (I have not tested in other browsers). Any idea how to do it? The only option I see is to include it directly in L
, not in L.Util
, but it breaks backwards compatibility 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is due to Leaflet's new rollup built system. I think moving it out of the utils again is the way to fix this.
Hmm, I'd say no to L.offsethelper
, can't we do L.sync.offsetHelper
, that would be better thanp putting it in the global L
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We also need to update the readme to state that this version and greater will support leaflet 1.1.0 and greater. Apart from that, it looks good. |
Could you do the note in the current readme before we merge this? Thanks. |
Yes, I'll do that, probably tomorrow. |
Just added the comment to the readme. |
c075d44
to
802d554
Compare
Grrrr. I found a new bug that happens in Firefox (and IE) 😞 . Unfortunately I use mainly/only Chrome. It makes a strange shake when you drag the map and then zoom in (and sometimes out) with the wheel or zoom control (+/-). |
By all means, please do!
… On 3 Jul 2017, at 21:57, Javier Jimenez Shaw ***@***.***> wrote:
Grrrr. I found a new bug that happens in Firefox (and IE) 😞 . Unfortunately I use mainly/only Chrome. It makes a strange shake when you drag the map and then zoom in (and sometimes out) with the wheel or zoom control (+/-).
It happens also in with Leaflet 1.0.3.
I will do a pull request for 1.0.3 with a workaround, before this one for 1.1.0. It is not perfect, but improves a lot this behaviour. Ok?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#45 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZvtUHxkCjeNKSItFF8kU1YPKBSkcyLks5sKUfEgaJpZM4OKUxF>.
|
This is interesting: the changes I have done to fix this shake or flicker in Firefox when zooming after drag (with inertia), make it compatible between 1.0.3 and 1.1.0 (we do not need onclick anymore, but we trigger the setView on moveend after a drag.). Good news. I understand that |
@jieter I think I have done all needed for the migration to 1.1.0, fixing the bug discovered in Firefox, and being compatible with both 1.0.3 and 1.1.0. |
Nice work! I'll merge and release next week when I'm back home |
Thanks. (#47 will probably conflict with this PR.) |
849e562
to
df9fa13
Compare
@jjimenezshaw merged, thanks! released 0.2.0 |
Migration to leaflet 1.1.0. :
Change dependency inpackage.json
?include
instead ofextend
withL.Map
. Was not working in 1.1.0 (see https://github.com/Leaflet/Leaflet/blob/master/PLUGIN-GUIDE.md#plugin-api)Removeclick
event call, due to fix Stop map on drag start instead of pointer down Leaflet/Leaflet#5378L.Util.offsetHelper
intoL.Sync.offsetHelper
. I was not able to extendL.Util
Tip to see the different version in a map: The minus character in the zoom control Leaflet/Leaflet#5501