Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: App forgets default activity ID #80

Merged
merged 6 commits into from
Oct 15, 2022
Merged

Fix: App forgets default activity ID #80

merged 6 commits into from
Oct 15, 2022

Conversation

jigarius
Copy link
Owner

  • The app relied on jQuery.val() to get the widget's value.
  • Now that we're not doing synchronous requests, there is a point when the default activity dropdown is empty.
  • Reading .val() at this point results in an empty value, thereby erasing it 😞
  • After these changes, we rely on data-selected in case .val() is empty.

@jigarius jigarius added the bug Something isn't working label Oct 15, 2022
@jigarius jigarius self-assigned this Oct 15, 2022
@jigarius
Copy link
Owner Author

I had to update some of the packages to fix errors and warnings.

@jigarius jigarius merged commit 328bf7c into 4.x Oct 15, 2022
@jigarius jigarius linked an issue Oct 15, 2022 that may be closed by this pull request
The plugin forgets the default activity after page reload #77
Closed
@jigarius jigarius deleted the dev/77-remember-default-activity branch July 2, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jigarius jigarius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The plugin forgets the default activity after page reload
1 participant
@jigarius