Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I noticed that some methods waste time by doing unnecessary work like clonning newly created buffers or allocating buffers larger than needed and decided to fix that. So I changed that, added some shortcuts here and there and changed
simpleRotate
in a way so in doesnt have to iterate over every pixel more than once in for any angle supported.Here are some numbers:
Jimp#rotate
(simpleRotate
)Jimp#flip
Jimp#crop
Buffer#slice
, so cropped image would uses same memory as old buffer, just with different offset,(note: following numbers also include time of clonning test image in every run)