-
Notifications
You must be signed in to change notification settings - Fork 66
docs: add notebook to demonstrate use of ArcFaceLoss #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have an example for ArcFace! Added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only about half way through. Why does the notebook and markdown file say the same thing? It's hard for me to keep track on both.
@scott-martens The markdown files are created from the notebooks, notebooks are easier to write and markdown files are easier to read in the docs. you can just review the markdown file |
I was already most of the way through with the notebook, so I continued to make my suggestions there. |
108d145
to
921ce1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only added some minor comments
📝 Docs are deployed on https://ft-docs-stanford-cars--jina-docs.netlify.app 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pr adds a new notebook to the documentation that uses
ArcFaceLoss
function.