Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: turn spanish tasks multilingual #11

Merged
merged 3 commits into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions mteb/tasks/Retrieval/MintakaESRetrieval.py

This file was deleted.

73 changes: 73 additions & 0 deletions mteb/tasks/Retrieval/MintakaRetrieval.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
import datasets

from ...abstasks import MultilingualTask
from ...abstasks.AbsTaskRetrieval import AbsTaskRetrieval

_EVAL_SPLIT = "test"
_LANGS = ["ar", "de", "es", "fr", "hi", "it", "ja", "pt"]


def _load_mintaka_data(path: str, langs: list, split: str, cache_dir: str = None, revision: str = None):
queries = {lang: {split: {}} for lang in langs}
corpus = {lang: {split: {}} for lang in langs}
relevant_docs = {lang: {split: {}} for lang in langs}

for lang in langs:
data = datasets.load_dataset(
path,
lang,
split=split,
cache_dir=cache_dir,
revision=revision,
)
question_ids = {question: _id for _id, question in enumerate(set(data["question"]))}
answer_ids = {answer: _id for _id, answer in enumerate(set(data["answer"]))}

for row in data:
question = row["question"]
answer = row["answer"]
query_id = f"Q{question_ids[question]}"
queries[lang][split][query_id] = question
doc_id = f"D{answer_ids[answer]}"
corpus[lang][split][doc_id] = {"text": answer}
if query_id not in relevant_docs[lang][split]:
relevant_docs[lang][split][query_id] = {}
relevant_docs[lang][split][query_id][doc_id] = 1

corpus = datasets.DatasetDict(corpus)
queries = datasets.DatasetDict(queries)
relevant_docs = datasets.DatasetDict(relevant_docs)

return corpus, queries, relevant_docs

class MintakaRetrieval(MultilingualTask, AbsTaskRetrieval):
@property
def description(self):
return {
"name": "MintakaRetrieval",
"hf_hub_name": "jinaai/mintakaqa",
"reference": "https://github.com/amazon-science/mintaka",
"description": (
"Mintaka: A Complex, Natural, and Multilingual Dataset for End-to-End Question Answering."
),
"type": "Retrieval",
"category": "s2s",
"eval_splits": [_EVAL_SPLIT],
"eval_langs": _LANGS,
"main_score": "ndcg_at_10",
"revision": "efa78cc2f74bbcd21eff2261f9e13aebe40b814e"
}

def load_data(self, **kwargs):
if self.data_loaded:
return

self.corpus, self.queries, self.relevant_docs = _load_mintaka_data(
path=self.description["hf_hub_name"],
langs=self.langs,
split=self.description["eval_splits"][0],
cache_dir=kwargs.get("cache_dir", None),
revision=self.description["revision"],
)

self.data_loaded = True
56 changes: 0 additions & 56 deletions mteb/tasks/Retrieval/XPQAESRetrieval.py

This file was deleted.

72 changes: 72 additions & 0 deletions mteb/tasks/Retrieval/XPQARetrieval.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import datasets

from ...abstasks import MultilingualTask
from ...abstasks.AbsTaskRetrieval import AbsTaskRetrieval

_EVAL_SPLIT = "test"
_LANGS = ["ar", "de", "es", "fr", "hi", "it", "ja", "ko", "pl", "pt", "ta", "zh"]


def _load_xpqa_data(path: str, langs: list, split: str, cache_dir: str = None, revision: str = None):
queries = {lang: {split: {}} for lang in langs}
corpus = {lang: {split: {}} for lang in langs}
relevant_docs = {lang: {split: {}} for lang in langs}

for lang in langs:
data = datasets.load_dataset(
path,
lang,
split=split,
cache_dir=cache_dir,
revision=revision,
)
question_ids = {question: _id for _id, question in enumerate(set(data["question"]))}
answer_ids = {answer: _id for _id, answer in enumerate(set(data["answer"]))}

for row in data:
question = row["question"]
answer = row["answer"]
query_id = f"Q{question_ids[question]}"
queries[lang][split][query_id] = question
doc_id = f"D{answer_ids[answer]}"
corpus[lang][split][doc_id] = {"text": answer}
if query_id not in relevant_docs[lang][split]:
relevant_docs[lang][split][query_id] = {}
relevant_docs[lang][split][query_id][doc_id] = 1

corpus = datasets.DatasetDict(corpus)
queries = datasets.DatasetDict(queries)
relevant_docs = datasets.DatasetDict(relevant_docs)

return corpus, queries, relevant_docs


class XPQARetrieval(MultilingualTask, AbsTaskRetrieval):
@property
def description(self):
return {
"name": "XPQARetrieval",
"hf_hub_name": "jinaai/xpqa",
"reference": "https://arxiv.org/abs/2305.09249",
"description": "xPQA is a large-scale annotated cross-lingual Product QA dataset.",
"type": "Retrieval",
"category": "s2s",
"eval_splits": [_EVAL_SPLIT],
"eval_langs": _LANGS,
"main_score": "ndcg_at_10",
"revision": "c99d599f0a6ab9b85b065da6f9d94f9cf731679f",
}

def load_data(self, **kwargs):
if self.data_loaded:
return

self.corpus, self.queries, self.relevant_docs = _load_xpqa_data(
path=self.description["hf_hub_name"],
langs=self.langs,
split=self.description["eval_splits"][0],
cache_dir=kwargs.get("cache_dir", None),
revision=self.description["revision"],
)

self.data_loaded = True
4 changes: 2 additions & 2 deletions mteb/tasks/Retrieval/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
from .KoMiracl import *
from .SpanishPassageRetrievalS2S import *
from .SpanishPassageRetrievalS2P import *
from .XPQAESRetrieval import *
from .MintakaESRetrieval import *
from .XPQARetrieval import *
from .MintakaRetrieval import *
from .MIRACLRetrieval import *
from .XMarketRetrieval import *