Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dyn batching configs #6204

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: dyn batching configs #6204

merged 1 commit into from
Sep 25, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 25, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.32%. Comparing base (d48f5a3) to head (703dcdd).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
jina/serve/runtimes/worker/request_handling.py 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d48f5a3) and HEAD (703dcdd). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (d48f5a3) HEAD (703dcdd)
jina 12 5
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6204      +/-   ##
==========================================
- Coverage   55.91%   49.32%   -6.59%     
==========================================
  Files         150      150              
  Lines       14217    14226       +9     
==========================================
- Hits         7949     7017     -932     
- Misses       6268     7209     +941     
Flag Coverage Δ
jina 49.32% <0.00%> (-6.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Sep 25, 2024
@JoanFM JoanFM merged commit b1139bc into master Sep 25, 2024
129 checks passed
@JoanFM JoanFM deleted the fix-endpoints-dyn-batch branch September 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant