Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install failed #70

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Fix npm install failed #70

merged 6 commits into from
Jul 16, 2020

Conversation

daxiondi
Copy link
Contributor

Following the last pr

@daxiondi daxiondi mentioned this pull request Jul 13, 2020
Closed
@daxiondi
Copy link
Contributor Author

@toby63

@daxiondi
Copy link
Contributor Author

@toby63 I am waiting for your code review.

@toby63
Copy link
Contributor

toby63 commented Jul 15, 2020

@daxiondi Can you rebase and squash the 6 commits into one?
Otherwise it looks good to me now.

@saghul Review requested.

@daxiondi
Copy link
Contributor Author

@saghul Waiting for your code review

@saghul saghul merged commit 6125355 into jitsi:master Jul 16, 2020
@saghul
Copy link
Member

saghul commented Jul 16, 2020

Thanks!

@daxiondi
Copy link
Contributor Author

@saghul hi，Do you have time to read this PR? I need your help.
Thanks @toby63 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxiondi @toby63 @saghul