Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meet.jit.si: Room name lowercased for moderators through auth flow #902

Closed
asmaloney opened this issue Aug 27, 2023 · 11 comments
Closed

meet.jit.si: Room name lowercased for moderators through auth flow #902

asmaloney opened this issue Aug 27, 2023 · 11 comments

Comments

@asmaloney
Copy link

Description

The room selection at the landing page has problems with the latest update 2023.08.01. It also changes the room names.

Current Behaviour

With the new login workflow, the room names get changed and the landing page with all the old room is... less useful (see below).

Expected Behaviour

Room names should be what I set them to and the links on the landing page should be what they used to be.

Possible Solution

Steps To Reproduce

  1. Click on an old room (e.g. "New Secret Room For Us")
Screen Shot 2023-08-26 at 19 22 26 PM
  1. It comes up with the new "Waiting for a moderator" blocking dialog
  2. Clicking "Log-In" takes me to an external browser simply to click the "Open Jitsi Meet.app" button
  3. It takes me back to the electron app, but the name of the room when I'm in has changed to "Newsecretroomforus"
  4. It didn't take me to the "holding page" like it used to before joining the room
  5. The landing page now has the following room (don't know if that's sensitive, so I blacked some out):
Screen Shot 2023-08-26 at 19 53 57 PM
  1. Clicking it puts me right into the room without the "holding area" that we used to have before actually joining the room (presumably because it's added that prejoinConfig thing on the URL).

Environment details

  • macOS 12.6.8
  • Jitsi Meet.app 2023.08.01
@saghul
Copy link
Member

saghul commented Aug 27, 2023

Hum, it's weird the redirect didn't take you straight into the meeting.

What system browser was opened for you to login?

@asmaloney
Copy link
Author

Hum, it's weird the redirect didn't take you straight into the meeting.

It did in step 4/5 (with a different room name). I would have expected it to leave me on the "holding page" so I could check the camera, etc. and click to actually join the meeting. I went looking for any prefs for that and didn't find any.

Step 6 (about the landing page) is after I've left the room or restarted the software.

@damencho
Copy link
Member

It did in step 4/5 (with a different room name). I would have expected it to leave me on the "holding page" so I could check the camera, etc. and click to actually join the meeting. I went looking for any prefs for that and didn't find any

But you have already been on that page and you have already clicked join. The idea is not to request from users to do the same operation twice.

Changing the link capital vs small case letters is not a problem. Welcome page has been already working like that, it removes spaces from the names you enter.

@asmaloney
Copy link
Author

But you have already been on that page and you have already clicked join.

Not really. When I clicked on the room in the landing page, it took me to the "holding page" but blocked me with a dialog to log in. When I do that, it drops me straight into the room. So I don't get to check the camera or mic, or adjust anything like I used to.

Changing the link capital vs small case letters is not a problem. Welcome page has been already working like that, it removes spaces from the names you enter.

Not a problem for who? I'm a user who has a problem with it 😄 The name of the room should match the name on the landing page or the one I type in to create a room. Before this, the name that shows up for the room has always been what I type in (or click from the landing page). Changing the room name is new to me.

Please keep in mind that not all people using this are tech-savvy, so this can be confusing for people. One of the first questions I (as organizer) got after this login change: why is the name goobledygook - that's not what I typed in. Am I in the right place?

Is there an issue with capitals and spaces? A URL encoding issue or something?

@csett86
Copy link
Member

csett86 commented Aug 27, 2023

Without auth, when you enter a room named ThisIsATest it is displayed in the conference as "This Is A Test", if I recall it correctly...

It seems that the new auth flow on meet.jit.si lowercases all characters in the room name, and with that the spaces in the display of the room name are lost.

@asmaloney
Copy link
Author

Is there a technical reason anything needs to modify the room name at all?

@asmaloney
Copy link
Author

(I know writing can sound harsh, so I just want to let you know where I'm coming from.)

FWIW the reason I'm pushing so much on UX is that 95% of the people I recommend Jitsi to are non-tech people (some who struggle with logging into their computer) & it is the simplest vid-chat to get them up-and-running. (And it's open source of course!)

So keeping it as simple & easy to use is very important to me.

I'm mainly a C++/go dev who really, really does not enjoy web dev, so I'm afraid I'm not in a position to contribute code - I can only offer opinions/suggestions based on lots of experience, and I can raise issues I find.

I really appreciate all your work on this project!

@csett86 csett86 changed the title Room name & landing page issues with new login workflow meet.jit.si: Room name lowercased and prejoin skipped with new auth flow Aug 27, 2023
@csett86 csett86 changed the title meet.jit.si: Room name lowercased and prejoin skipped with new auth flow meet.jit.si: Room name lowercased and prejoin skipped with new auth flow for moderators Aug 27, 2023
@saghul
Copy link
Member

saghul commented Aug 27, 2023

Is there a technical reason anything needs to modify the room name at all?

No, it's likely a small bug in the rendering, since internally room names are all lowercase and without spaces.

@mankoff
Copy link

mankoff commented Aug 28, 2023

Step 6 (about the landing page) is after I've left the room or restarted the software.

I found that a CTRL+r (refresh) works too. After logging in using the browser I'm returned to the Jitsi App, but it still just shows 'Waiting for moderator' until I refresh (then instantly join). Easier than leaving + re-entering.

@mankoff
Copy link

mankoff commented Aug 28, 2023

Speaking of 'rendering', it would be nice if the jwt string was not rendered in the recent room list shown on the Electron homepage.

@saghul
Copy link
Member

saghul commented Aug 28, 2023

Yep this is currently a known issue I plan on addressing shortly. Any PR is welcome though.

@csett86 csett86 changed the title meet.jit.si: Room name lowercased and prejoin skipped with new auth flow for moderators meet.jit.si: Room name lowercased Sep 4, 2023
@csett86 csett86 changed the title meet.jit.si: Room name lowercased meet.jit.si: Room name lowercased for moderators through auth flow Sep 4, 2023
saghul added a commit that referenced this issue Sep 5, 2023
damencho added a commit to jitsi/jitsi-meet that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants