Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.11.2 requires at least jitsi-meet-web 1.0.7658-1, otherwise it returns to the main screen after 30sec #929

Closed
seregasoft opened this issue Nov 23, 2023 · 8 comments · Fixed by #931

Comments

@seregasoft
Copy link

Description

2023.11.2 returns to the main screen after ~30sec after join

Current behavior

v. 2023.11.2 sudden exit from the conference and returns to the main screen after ~30sec after join

Expected Behavior

I continue to be in the conference

Possible Solution

Workaround: use browser

Steps to reproduce

Join to conference using jitsi-meet-electron v. 2023.11.2
Wait 30 seconds

Environment details

OS Windows 10
Client: jitsi-meet-electron v. 2023.11.2
Server:
jitsi-meet-prosody/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-turnserver/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-web-config/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-web/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet/stable,now 2.0.7882-1 all [installed,upgradable to: 2.0.9111-1]
jitsi-videobridge2/stable,now 2.2-45-ge8b20f06-1 all [installed,upgradable to: 2.3-61-g814bffd6-1]

@saghul
Copy link
Member

saghul commented Nov 23, 2023

Can you reproduce this on meet.jit.si ?

@csett86
Copy link
Member

csett86 commented Nov 23, 2023

I can reproduce it with jitsi-meet-web 1.0.7531-1, but not on meet.jit.si.

The timeout that this app uses (30 seconds by default) somehow fires, so the app no longer detects that it has joined the conference successfully... Nothing that I would find in the developer tools of electron so far...

Will check with current stable jitsi-meet-web 1.0.7658-1 as well.

@csett86
Copy link
Member

csett86 commented Nov 23, 2023

Good news, I cannot reproduce it with stable jitsi-meet-web 1.0.7658-1

@csett86 csett86 changed the title 2023.11.2 returns to the main screen after 30sec 2023.11.2 requires at least jitsi-meet-web 1.0.7658-1, otherwise it returns to the main screen after 30sec Nov 23, 2023
@csett86 csett86 pinned this issue Nov 23, 2023
@saghul
Copy link
Member

saghul commented Nov 23, 2023

It's weird, however that it doesn't work with older versions. @gabiborlea can you PTAL tomorrow?

@gabiborlea
Copy link
Contributor

Found the issue! The problem is that the onload function is not called and the loadTimer timeout is not cleared and forces you out of the conference:

. This is caused by the fact that the external_api does not call the onload method when the iframe is loaded. I suppose its because of this: jitsi/jitsi-meet@59242e1. As the old jitsi meet version has an older API module the ready event will never be triggered in the external_api, and onload was dropped from the createIFrame function it will never be called. The solution would be either to create a patch for the external_api for electron, or the make the external_api from jitsi-meet backwards compatible with older versions. What do you think @saghul ?

saghul added a commit that referenced this issue Nov 24, 2023
Use an iframe event which is fired really early to detect if the iframe
was loaded.

Incidentally the logic to detect if the iframe was actually loaded gets
simplified now, since the only way for the event to be received is for
the iframe to be loaded.

Fixes: #929
@saghul
Copy link
Member

saghul commented Nov 24, 2023

Fix: #931

saghul added a commit that referenced this issue Nov 24, 2023
Use an iframe event which is fired really early to detect if the iframe
was loaded.

Incidentally the logic to detect if the iframe was actually loaded gets
simplified now, since the only way for the event to be received is for
the iframe to be loaded.

Fixes: #929
@osnyx
Copy link

osnyx commented Nov 24, 2023

Thanks for quickly working on this.
I permit myself to use this as an example where automated updates that cannot be turned off or do not need to be confirmed are a bit annoying or harmful. I was the first one to update the electron app and was able to inform everyone in my team about the breakage, but they still had no choice of not updating, or did I miss anything?

@saghul saghul unpinned this issue Nov 24, 2023
@saghul
Copy link
Member

saghul commented Nov 24, 2023

This application is basically a browser in disguise, with all its advantages and disadvantages. We follow the same update model as all modern web browsers for security reasons.

We will occasinally mess up, that's a fact of life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants