-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.11.2 requires at least jitsi-meet-web 1.0.7658-1, otherwise it returns to the main screen after 30sec #929
Comments
Can you reproduce this on meet.jit.si ? |
I can reproduce it with jitsi-meet-web 1.0.7531-1, but not on meet.jit.si. The timeout that this app uses (30 seconds by default) somehow fires, so the app no longer detects that it has joined the conference successfully... Nothing that I would find in the developer tools of electron so far... Will check with current stable jitsi-meet-web 1.0.7658-1 as well. |
Good news, I cannot reproduce it with stable jitsi-meet-web 1.0.7658-1 |
It's weird, however that it doesn't work with older versions. @gabiborlea can you PTAL tomorrow? |
Found the issue! The problem is that the
ready event will never be triggered in the external_api, and onload was dropped from the createIFrame function it will never be called. The solution would be either to create a patch for the external_api for electron, or the make the external_api from jitsi-meet backwards compatible with older versions. What do you think @saghul ?
|
Use an iframe event which is fired really early to detect if the iframe was loaded. Incidentally the logic to detect if the iframe was actually loaded gets simplified now, since the only way for the event to be received is for the iframe to be loaded. Fixes: #929
Fix: #931 |
Use an iframe event which is fired really early to detect if the iframe was loaded. Incidentally the logic to detect if the iframe was actually loaded gets simplified now, since the only way for the event to be received is for the iframe to be loaded. Fixes: #929
Thanks for quickly working on this. |
This application is basically a browser in disguise, with all its advantages and disadvantages. We follow the same update model as all modern web browsers for security reasons. We will occasinally mess up, that's a fact of life. |
Description
2023.11.2 returns to the main screen after ~30sec after join
Current behavior
v. 2023.11.2 sudden exit from the conference and returns to the main screen after ~30sec after join
Expected Behavior
I continue to be in the conference
Possible Solution
Workaround: use browser
Steps to reproduce
Join to conference using jitsi-meet-electron v. 2023.11.2
Wait 30 seconds
Environment details
OS Windows 10
Client: jitsi-meet-electron v. 2023.11.2
Server:
jitsi-meet-prosody/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-turnserver/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-web-config/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet-web/stable,now 1.0.6644-1 all [installed,upgradable to: 1.0.7658-1]
jitsi-meet/stable,now 2.0.7882-1 all [installed,upgradable to: 2.0.9111-1]
jitsi-videobridge2/stable,now 2.2-45-ge8b20f06-1 all [installed,upgradable to: 2.3-61-g814bffd6-1]
The text was updated successfully, but these errors were encountered: