feat: Support setting the initial value of last-n through colibri2. #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.info("Setting initialLastN = $initialLastN") | ||
| bitrateController.lastN = initialLastN | ||
| } else { | ||
| logger.info("Ignoring initialLastN, message transport already connected.") |
There was a problem hiding this comment.
Seems like there's still a race here - the threshold for ignoring the initialLastN should be that receiver constraints have been received, not that the message transport is connected. (Data will come after the connect for both websocket and datachannel.)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
============================================
- Coverage 43.04% 43.02% -0.03%
Complexity 1668 1668
============================================
Files 323 323
Lines 16740 16750 +10
Branches 2202 2203 +1
============================================
Hits 7206 7206
- Misses 8830 8840 +10
Partials 704 704
Continue to review full report in Codecov by Sentry.
|
JonathanLennox
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.